Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-11 Thread Heikki Krogerus
Hi Guenter, On Tue, Jan 10, 2017 at 09:35:42AM -0800, Guenter Roeck wrote: > > I guess we might as well then split the VDO into header, cert stat and > > product parts. What do you think? > > > > If it's OK, then should we change that file to "identity" and dump the > > whole response from Discov

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-11 Thread Oliver Neukum
On Wed, 2017-01-11 at 09:57 +0200, Heikki Krogerus wrote: > On Tue, Jan 10, 2017 at 11:08:51AM +0100, Oliver Neukum wrote: > > > And since we are talking about the ABI, can we also change the listing > > > of the accessory mode back to just "audio" and "debug" like I > > > originally had it? I don'

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-10 Thread Heikki Krogerus
On Tue, Jan 10, 2017 at 11:08:51AM +0100, Oliver Neukum wrote: > > And since we are talking about the ABI, can we also change the listing > > of the accessory mode back to just "audio" and "debug" like I > > originally had it? I don't remember who and why wanted it to be > > changed to "Audio Adapt

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-10 Thread Guenter Roeck
On Tue, Jan 10, 2017 at 04:46:12PM +0200, Heikki Krogerus wrote: > On Tue, Jan 10, 2017 at 05:50:04AM -0800, Guenter Roeck wrote: > > On 01/10/2017 12:54 AM, Heikki Krogerus wrote: > > > Hi Guenter, > > > > > > On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: > > > > > +/** > > > > >

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-10 Thread Heikki Krogerus
On Tue, Jan 10, 2017 at 05:50:04AM -0800, Guenter Roeck wrote: > On 01/10/2017 12:54 AM, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: > > > > +/** > > > > + * typec_register_partner - Register a USB Type-C Partner > > > > + * @port:

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-10 Thread Guenter Roeck
On 01/10/2017 12:54 AM, Heikki Krogerus wrote: Hi Guenter, On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: +/** + * typec_register_partner - Register a USB Type-C Partner + * @port: The USB Type-C Port the partner is connected to + * @desc: Description of the partner + * + * Regi

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-10 Thread Oliver Neukum
On Fri, 2017-01-06 at 12:54 +0200, Heikki Krogerus wrote: > Hi guys, > > On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > I wonder if "source sink" instead is better? Along the lines of > > /sys/power/state. > > > > Then you can print "[source] sink" when source is selected

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-10 Thread Heikki Krogerus
Hi Guenter, On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: > > +/** > > + * typec_register_partner - Register a USB Type-C Partner > > + * @port: The USB Type-C Port the partner is connected to > > + * @desc: Description of the partner > > + * > > + * Registers a device for USB Typ

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-09 Thread Guenter Roeck
Hello Heikki, On Thu, Jan 05, 2017 at 02:01:18PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-06 Thread Guenter Roeck
On Fri, Jan 06, 2017 at 12:54:05PM +0200, Heikki Krogerus wrote: > Hi guys, > > On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > > +static ssize_t > > > +typec_altmode_roles_show(struct device *dev, struct device_attribute > > > *attr, > > > + char *buf) > > >

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-06 Thread Heikki Krogerus
Hi guys, On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > +static ssize_t > > +typec_altmode_roles_show(struct device *dev, struct device_attribute *attr, > > +char *buf) > > +{ > > + struct typec_mode *mode = container_of(attr, struct typec_mode, > > +

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-05 Thread Greg KH
On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > + > > + ret = device_register(&alt->dev); > > + if (ret) { > > + int i; > > + > > + dev_err(parent, "failed to register alternate mode (%d)\n", > > + ret); > > + > > + put_device

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-05 Thread Mika Westerberg
On Thu, Jan 05, 2017 at 02:01:18PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port s

[PATCHv14 2/3] usb: USB Type-C connector class

2017-01-05 Thread Heikki Krogerus
The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and Alt