Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-30 Thread Borislav Petkov
On Mon, Oct 27, 2014 at 05:48:17PM -0500, Thor Thayer wrote: > Would the L2 cache and OCRAM specific functions also be in altera_edac.c? > Each of these EDAC pieces is independent and can be compiled in without the > others. I've read that the use of #ifdef's is discouraged and having > separate

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-30 Thread Borislav Petkov
On Mon, Oct 27, 2014 at 05:48:17PM -0500, Thor Thayer wrote: Would the L2 cache and OCRAM specific functions also be in altera_edac.c? Each of these EDAC pieces is independent and can be compiled in without the others. I've read that the use of #ifdef's is discouraged and having separate files

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Thor Thayer
On 10/27/2014 04:59 PM, Borislav Petkov wrote: On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote: Should I move the EDAC Device probe and error handling from altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models in the same file? Right, for basic practical reasons,

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Borislav Petkov
On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote: > Should I move the EDAC Device probe and error handling from > altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models > in the same file? Right, for basic practical reasons, I'd like to keep all functionality pertaining

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Thor Thayer
On 10/27/2014 03:43 PM, Borislav Petkov wrote: On Mon, Oct 27, 2014 at 01:50:24PM -0500, Thor Thayer wrote: Do you have any comments about this driver? Just a question: why do you have three .c files for something which does only error injection and nothing else AFAICT? Why isn't this part of

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Borislav Petkov
On Mon, Oct 27, 2014 at 01:50:24PM -0500, Thor Thayer wrote: > Do you have any comments about this driver? Just a question: why do you have three .c files for something which does only error injection and nothing else AFAICT? Why isn't this part of altera_edac.c? -- Regards/Gruss, Boris.

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Thor Thayer
Hi Borislav, On 10/17/2014 03:33 PM, ttha...@opensource.altera.com wrote: From: Thor Thayer This patch adds the L2 cache and OCRAM peripherals to the EDAC framework using the EDAC device framework. The ECC is enabled early in the boot process in the platform specific code. Thor Thayer (4):

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Thor Thayer
Hi Borislav, On 10/17/2014 03:33 PM, ttha...@opensource.altera.com wrote: From: Thor Thayer ttha...@opensource.altera.com This patch adds the L2 cache and OCRAM peripherals to the EDAC framework using the EDAC device framework. The ECC is enabled early in the boot process in the platform

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Borislav Petkov
On Mon, Oct 27, 2014 at 01:50:24PM -0500, Thor Thayer wrote: Do you have any comments about this driver? Just a question: why do you have three .c files for something which does only error injection and nothing else AFAICT? Why isn't this part of altera_edac.c? -- Regards/Gruss, Boris.

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Thor Thayer
On 10/27/2014 03:43 PM, Borislav Petkov wrote: On Mon, Oct 27, 2014 at 01:50:24PM -0500, Thor Thayer wrote: Do you have any comments about this driver? Just a question: why do you have three .c files for something which does only error injection and nothing else AFAICT? Why isn't this part of

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Borislav Petkov
On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote: Should I move the EDAC Device probe and error handling from altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models in the same file? Right, for basic practical reasons, I'd like to keep all functionality pertaining to

Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-27 Thread Thor Thayer
On 10/27/2014 04:59 PM, Borislav Petkov wrote: On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote: Should I move the EDAC Device probe and error handling from altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models in the same file? Right, for basic practical reasons,

[PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-17 Thread tthayer
From: Thor Thayer This patch adds the L2 cache and OCRAM peripherals to the EDAC framework using the EDAC device framework. The ECC is enabled early in the boot process in the platform specific code. Thor Thayer (4): arm: socfpga: Enable L2 Cache ECC on startup. arm: socfpga: Enable OCRAM

[PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

2014-10-17 Thread tthayer
From: Thor Thayer ttha...@opensource.altera.com This patch adds the L2 cache and OCRAM peripherals to the EDAC framework using the EDAC device framework. The ECC is enabled early in the boot process in the platform specific code. Thor Thayer (4): arm: socfpga: Enable L2 Cache ECC on startup.