Re: [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Mark Brown
On Mon, Mar 03, 2014 at 03:01:52AM +, li.xi...@freescale.com wrote: > I think we should move the set_cache_io() calling more earlier as we discussed > before, but need much more research and testing. Splitting them into another > separate patch later will be much better and easier to be review

RE: [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> > "Just removing the set_cache_io() call will not work for all > > drivers. There are some MFD child devices which use regmap from the parent > > device. So dev_get_regmap() will return NULL for those." > > This is the sort of thing that I was referring to when talking about > doing the non-bori

RE: [alsa-devel] [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> Looks good in general, but try to build these kinds of changes with > CONFIG_COMPILE_TEST=y and CONFIG_SND_SOC_ALL_CODECS=y before sending the > patch. There are a lot of warnings about unused variables caused by this > patch. > @Lars, Oh, yes, these are very low-level errors, I will fix them

Re: [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-02-28 Thread Mark Brown
On Fri, Feb 28, 2014 at 05:04:25PM +0800, Xiubo Li wrote: > "Just removing the set_cache_io() call will not work for all > drivers. There are some MFD child devices which use regmap from the parent > device. So dev_get_regmap() will return NULL for those." This is the sort of thing that I was r

Re: [alsa-devel] [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-02-28 Thread Lars-Peter Clausen
On 02/28/2014 10:04 AM, Xiubo Li wrote: Signed-off-by: Xiubo Li --- @Mark, @Lars, @All, I have checked for each driver about the following issue from Lars: "Just removing the set_cache_io() call will not work for all drivers. There are some MFD child devices which use regmap from the parent d

[PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-02-28 Thread Xiubo Li
Signed-off-by: Xiubo Li --- @Mark, @Lars, @All, I have checked for each driver about the following issue from Lars: "Just removing the set_cache_io() call will not work for all drivers. There are some MFD child devices which use regmap from the parent device. So dev_get_regmap() will return N