Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-11 Thread David Miller
From: Linus Lüssing Date: Mon, 10 Mar 2014 22:25:25 +0100 > Without this check someone could easily create a denial of service > by injecting multicast-specific queries to enable the bridge > snooping part if no real querier issuing periodic general queries > is present on the link which would

Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-11 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Mon, 10 Mar 2014 22:25:25 +0100 Without this check someone could easily create a denial of service by injecting multicast-specific queries to enable the bridge snooping part if no real querier issuing periodic general queries is present on the

Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-10 Thread Linus Lüssing
On Mon, Mar 10, 2014 at 11:56:00PM +0100, Hannes Frederic Sowa wrote: > On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote: > > br_multicast_query_received(br, port, >ip6_querier, > > - !ipv6_addr_any(>saddr), max_delay); > > +

Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-10 Thread Hannes Frederic Sowa
On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote: > br_multicast_query_received(br, port, >ip6_querier, > - !ipv6_addr_any(>saddr), max_delay); > + !ipv6_addr_any(>saddr), > +

[PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-10 Thread Linus Lüssing
Without this check someone could easily create a denial of service by injecting multicast-specific queries to enable the bridge snooping part if no real querier issuing periodic general queries is present on the link which would result in the bridge wrongly shutting down ports for multicast

[PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-10 Thread Linus Lüssing
Without this check someone could easily create a denial of service by injecting multicast-specific queries to enable the bridge snooping part if no real querier issuing periodic general queries is present on the link which would result in the bridge wrongly shutting down ports for multicast

Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-10 Thread Hannes Frederic Sowa
On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote: br_multicast_query_received(br, port, br-ip6_querier, - !ipv6_addr_any(ip6h-saddr), max_delay); + !ipv6_addr_any(ip6h-saddr), +

Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-10 Thread Linus Lüssing
On Mon, Mar 10, 2014 at 11:56:00PM +0100, Hannes Frederic Sowa wrote: On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote: br_multicast_query_received(br, port, br-ip6_querier, - !ipv6_addr_any(ip6h-saddr), max_delay); +