Re: [alsa-devel] [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-03-01 Thread Lars-Peter Clausen
On 03/01/2014 05:34 AM, Mark Brown wrote: On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote: Now that all users have been converted to regmap and the config.reg_bits and config.val_bits can be setted by each user through regmap core API. So these two params are redundant here.

Re: [alsa-devel] [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-03-01 Thread Lars-Peter Clausen
On 03/01/2014 05:34 AM, Mark Brown wrote: On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote: Now that all users have been converted to regmap and the config.reg_bits and config.val_bits can be setted by each user through regmap core API. So these two params are redundant here.

Re: [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-02-28 Thread Mark Brown
On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote: > Now that all users have been converted to regmap and the config.reg_bits > and config.val_bits can be setted by each user through regmap core API. > So these two params are redundant here. Actually, I think the way to fix the issue with

Re: [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-02-28 Thread Mark Brown
On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote: > Now that all users have been converted to regmap and the config.reg_bits > and config.val_bits can be setted by each user through regmap core API. > So these two params are redundant here. This looks good. signature.asc Description:

[PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-02-28 Thread Xiubo Li
Now that all users have been converted to regmap and the config.reg_bits and config.val_bits can be setted by each user through regmap core API. So these two params are redundant here. Since the only control type that left is SND_SOC_REGMAP, so remove it. Drop the control params and add struct

[PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-02-28 Thread Xiubo Li
Now that all users have been converted to regmap and the config.reg_bits and config.val_bits can be setted by each user through regmap core API. So these two params are redundant here. Since the only control type that left is SND_SOC_REGMAP, so remove it. Drop the control params and add struct

Re: [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-02-28 Thread Mark Brown
On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote: Now that all users have been converted to regmap and the config.reg_bits and config.val_bits can be setted by each user through regmap core API. So these two params are redundant here. This looks good. signature.asc Description:

Re: [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()

2014-02-28 Thread Mark Brown
On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote: Now that all users have been converted to regmap and the config.reg_bits and config.val_bits can be setted by each user through regmap core API. So these two params are redundant here. Actually, I think the way to fix the issue with