Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-24 Thread Li, Yi
On 5/23/2017 10:25 AM, Alan Tull wrote: On Tue, May 23, 2017 at 10:21 AM, Alan Tull wrote: + + mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ; + while (length > 0) { This could be "do { ... } while ((params.fw_size >= FIRMWARE_CHUNK_SZ) && (length > 0));" since

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-24 Thread Li, Yi
On 5/23/2017 10:25 AM, Alan Tull wrote: On Tue, May 23, 2017 at 10:21 AM, Alan Tull wrote: + + mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ; + while (length > 0) { This could be "do { ... } while ((params.fw_size >= FIRMWARE_CHUNK_SZ) && (length > 0));" since that's what it's

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-24 Thread Li, Yi
On 5/23/2017 10:25 AM, Alan Tull wrote: On Tue, May 23, 2017 at 10:21 AM, Alan Tull wrote: + + mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ; + while (length > 0) { This could be "do { ... } while ((params.fw_size >= FIRMWARE_CHUNK_SZ) && (length > 0));" since

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-24 Thread Li, Yi
On 5/23/2017 10:25 AM, Alan Tull wrote: On Tue, May 23, 2017 at 10:21 AM, Alan Tull wrote: + + mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ; + while (length > 0) { This could be "do { ... } while ((params.fw_size >= FIRMWARE_CHUNK_SZ) && (length > 0));" since that's what it's

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-23 Thread Alan Tull
On Tue, May 23, 2017 at 10:21 AM, Alan Tull wrote: + + mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ; + while (length > 0) { >>> >>> This could be "do { ... } while ((params.fw_size >= FIRMWARE_CHUNK_SZ) >>> && (length > 0));" since that's what it's really

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-23 Thread Alan Tull
On Tue, May 23, 2017 at 10:21 AM, Alan Tull wrote: + + mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ; + while (length > 0) { >>> >>> This could be "do { ... } while ((params.fw_size >= FIRMWARE_CHUNK_SZ) >>> && (length > 0));" since that's what it's really doing. >> >> Yes,

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-23 Thread Alan Tull
On Mon, May 22, 2017 at 11:11 PM, Li, Yi wrote: > hi Alan > > > On 5/22/2017 4:09 PM, Alan Tull wrote: >> >> On Sat, May 20, 2017 at 1:49 AM, wrote: >> >> Hi Yi, >> >>> From: Yi Li >>> >>> Since the FPGA image are getting

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-23 Thread Alan Tull
On Mon, May 22, 2017 at 11:11 PM, Li, Yi wrote: > hi Alan > > > On 5/22/2017 4:09 PM, Alan Tull wrote: >> >> On Sat, May 20, 2017 at 1:49 AM, wrote: >> >> Hi Yi, >> >>> From: Yi Li >>> >>> Since the FPGA image are getting bigger in size, this add an new API >>> fpga_mgr_firmware_stream >> >>

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-22 Thread Li, Yi
hi Alan On 5/22/2017 4:09 PM, Alan Tull wrote: On Sat, May 20, 2017 at 1:49 AM, wrote: Hi Yi, From: Yi Li Since the FPGA image are getting bigger in size, this add an new API fpga_mgr_firmware_stream You could replace the guts of the

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-22 Thread Li, Yi
hi Alan On 5/22/2017 4:09 PM, Alan Tull wrote: On Sat, May 20, 2017 at 1:49 AM, wrote: Hi Yi, From: Yi Li Since the FPGA image are getting bigger in size, this add an new API fpga_mgr_firmware_stream You could replace the guts of the current fpga_mgr_firmware_load() with this new API

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-22 Thread Alan Tull
On Sat, May 20, 2017 at 1:49 AM, wrote: Hi Yi, > From: Yi Li > > Since the FPGA image are getting bigger in size, this add an new API > fpga_mgr_firmware_stream You could replace the guts of the current fpga_mgr_firmware_load() with this new

Re: [PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-22 Thread Alan Tull
On Sat, May 20, 2017 at 1:49 AM, wrote: Hi Yi, > From: Yi Li > > Since the FPGA image are getting bigger in size, this add an new API > fpga_mgr_firmware_stream You could replace the guts of the current fpga_mgr_firmware_load() with this new API (keep the old name). Unless anyone can think

[PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-20 Thread yi1 . li
From: Yi Li Since the FPGA image are getting bigger in size, this add an new API fpga_mgr_firmware_stream in FPGA manager, which will stream FPGA image in 4KB trunks. Signed-off-by: Yi Li --- drivers/fpga/fpga-mgr.c | 111

[PATCHv2 3/3] fpga_mgr: Add streaming support through the new driver_data API

2017-05-20 Thread yi1 . li
From: Yi Li Since the FPGA image are getting bigger in size, this add an new API fpga_mgr_firmware_stream in FPGA manager, which will stream FPGA image in 4KB trunks. Signed-off-by: Yi Li --- drivers/fpga/fpga-mgr.c | 111 ++