Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-08-10 Thread Dmitry Safonov
On 08/10/2016 11:35 AM, Andy Lutomirski wrote: On Tue, Aug 2, 2016 at 3:59 AM, Dmitry Safonov wrote: On 07/12/2016 05:14 PM, Oleg Nesterov wrote: On 07/11, Andy Lutomirski wrote: I'm starting to wonder if we should finally suck it up and give special mappings a

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-08-10 Thread Dmitry Safonov
On 08/10/2016 11:35 AM, Andy Lutomirski wrote: On Tue, Aug 2, 2016 at 3:59 AM, Dmitry Safonov wrote: On 07/12/2016 05:14 PM, Oleg Nesterov wrote: On 07/11, Andy Lutomirski wrote: I'm starting to wonder if we should finally suck it up and give special mappings a non-NULL vm_file so we can

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-08-10 Thread Andy Lutomirski
On Tue, Aug 2, 2016 at 3:59 AM, Dmitry Safonov wrote: > On 07/12/2016 05:14 PM, Oleg Nesterov wrote: >> >> On 07/11, Andy Lutomirski wrote: >>> >>> I'm starting to wonder if we should finally suck it up and give >>> special mappings a non-NULL vm_file so we can track them

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-08-10 Thread Andy Lutomirski
On Tue, Aug 2, 2016 at 3:59 AM, Dmitry Safonov wrote: > On 07/12/2016 05:14 PM, Oleg Nesterov wrote: >> >> On 07/11, Andy Lutomirski wrote: >>> >>> I'm starting to wonder if we should finally suck it up and give >>> special mappings a non-NULL vm_file so we can track them properly. >>> Oleg,

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-08-02 Thread Dmitry Safonov
On 07/12/2016 05:14 PM, Oleg Nesterov wrote: On 07/11, Andy Lutomirski wrote: I'm starting to wonder if we should finally suck it up and give special mappings a non-NULL vm_file so we can track them properly. Oleg, weren't you thinking of doing that for some other reason? Yes, uprobes.

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-08-02 Thread Dmitry Safonov
On 07/12/2016 05:14 PM, Oleg Nesterov wrote: On 07/11, Andy Lutomirski wrote: I'm starting to wonder if we should finally suck it up and give special mappings a non-NULL vm_file so we can track them properly. Oleg, weren't you thinking of doing that for some other reason? Yes, uprobes.

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-12 Thread Oleg Nesterov
On 07/11, Andy Lutomirski wrote: > > On Mon, Jul 11, 2016 at 11:26 AM, Oleg Nesterov wrote: > > > > Do we really care? I mean, the kernel can't crash or something like this, > > just the old vdso mapping can faultin the "wrong" page from the new > > vdso_image, right? > > That

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-12 Thread Oleg Nesterov
On 07/11, Andy Lutomirski wrote: > > On Mon, Jul 11, 2016 at 11:26 AM, Oleg Nesterov wrote: > > > > Do we really care? I mean, the kernel can't crash or something like this, > > just the old vdso mapping can faultin the "wrong" page from the new > > vdso_image, right? > > That makes me nervous.

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-11 Thread Andy Lutomirski
On Mon, Jul 11, 2016 at 11:26 AM, Oleg Nesterov wrote: > On 07/10, Andy Lutomirski wrote: >> >> On Thu, Jul 7, 2016 at 4:11 AM, Dmitry Safonov >> wrote: >> > On 07/06/2016 05:30 PM, Andy Lutomirski wrote: >> >> >> >> On Wed, Jun 29, 2016 at 3:57 AM,

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-11 Thread Andy Lutomirski
On Mon, Jul 11, 2016 at 11:26 AM, Oleg Nesterov wrote: > On 07/10, Andy Lutomirski wrote: >> >> On Thu, Jul 7, 2016 at 4:11 AM, Dmitry Safonov >> wrote: >> > On 07/06/2016 05:30 PM, Andy Lutomirski wrote: >> >> >> >> On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov >> >> wrote: >> >>> >> >>>

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-11 Thread Oleg Nesterov
On 07/10, Andy Lutomirski wrote: > > On Thu, Jul 7, 2016 at 4:11 AM, Dmitry Safonov wrote: > > On 07/06/2016 05:30 PM, Andy Lutomirski wrote: > >> > >> On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov > >> wrote: > >>> > >>> Add API to change vdso

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-11 Thread Oleg Nesterov
On 07/10, Andy Lutomirski wrote: > > On Thu, Jul 7, 2016 at 4:11 AM, Dmitry Safonov wrote: > > On 07/06/2016 05:30 PM, Andy Lutomirski wrote: > >> > >> On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov > >> wrote: > >>> > >>> Add API to change vdso blob type with arch_prctl. > >>> As this is

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-10 Thread Andy Lutomirski
On Thu, Jul 7, 2016 at 4:11 AM, Dmitry Safonov wrote: > On 07/06/2016 05:30 PM, Andy Lutomirski wrote: >> >> On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov >> wrote: >>> >>> Add API to change vdso blob type with arch_prctl. >>> As this is usefull

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-10 Thread Andy Lutomirski
On Thu, Jul 7, 2016 at 4:11 AM, Dmitry Safonov wrote: > On 07/06/2016 05:30 PM, Andy Lutomirski wrote: >> >> On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov >> wrote: >>> >>> Add API to change vdso blob type with arch_prctl. >>> As this is usefull only by needs of CRIU, expose >>> this interface

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-07 Thread Dmitry Safonov
On 07/06/2016 05:30 PM, Andy Lutomirski wrote: On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov wrote: Add API to change vdso blob type with arch_prctl. As this is usefull only by needs of CRIU, expose this interface under CONFIG_CHECKPOINT_RESTORE. +#ifdef

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-07 Thread Dmitry Safonov
On 07/06/2016 05:30 PM, Andy Lutomirski wrote: On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov wrote: Add API to change vdso blob type with arch_prctl. As this is usefull only by needs of CRIU, expose this interface under CONFIG_CHECKPOINT_RESTORE. +#ifdef CONFIG_CHECKPOINT_RESTORE +

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-06 Thread Andy Lutomirski
On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov wrote: > Add API to change vdso blob type with arch_prctl. > As this is usefull only by needs of CRIU, expose > this interface under CONFIG_CHECKPOINT_RESTORE. > +#ifdef CONFIG_CHECKPOINT_RESTORE > + case

Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-07-06 Thread Andy Lutomirski
On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov wrote: > Add API to change vdso blob type with arch_prctl. > As this is usefull only by needs of CRIU, expose > this interface under CONFIG_CHECKPOINT_RESTORE. > +#ifdef CONFIG_CHECKPOINT_RESTORE > + case ARCH_MAP_VDSO_X32: > +

[PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-06-29 Thread Dmitry Safonov
Add API to change vdso blob type with arch_prctl. As this is usefull only by needs of CRIU, expose this interface under CONFIG_CHECKPOINT_RESTORE. Cc: Andy Lutomirski Cc: Ingo Molnar Cc: Thomas Gleixner Cc: "H. Peter Anvin"

[PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

2016-06-29 Thread Dmitry Safonov
Add API to change vdso blob type with arch_prctl. As this is usefull only by needs of CRIU, expose this interface under CONFIG_CHECKPOINT_RESTORE. Cc: Andy Lutomirski Cc: Ingo Molnar Cc: Thomas Gleixner Cc: "H. Peter Anvin" Cc: Cyrill Gorcunov Cc: Pavel Emelyanov Cc: x...@kernel.org