Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread David Miller
From: Linus Lüssing Date: Fri, 22 May 2015 15:32:37 +0200 > @@ -1786,14 +1784,8 @@ int br_multicast_set_router(struct net_bridge *br, > unsigned long val) > case 1: > br->multicast_router = val; > err = 0; > - break; > - > - default: > -

Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 6:32 AM, Linus Lüssing wrote: > Changelog v2: > * remove another now unnecessary -ENOENT initialization > * consistently initialize to -EINVAL, allowing to shorten two switch-cases > Looks perfect now. :) Thanks for update. -- To unsubscribe from this list: send the line

[PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread Linus Lüssing
Network managers like netifd (used in OpenWRT for instance) try to configure interface options after creation but before setting the interface up. Unfortunately the sysfs / bridge currently only allows to configure the hash_max and multicast_router options when the bridge interface is up. But sinc