Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-29 Thread Archit Taneja
On 11/23/2017 05:52 AM, John Stultz wrote: On Tue, Nov 21, 2017 at 12:17 AM, Hans Verkuil wrote: If the device tree for a board did not specify a cec clock, then adv7511_cec_init would return an error, which would cause adv7511_probe() to fail and thus there is no HDMI

Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-29 Thread Archit Taneja
On 11/23/2017 05:52 AM, John Stultz wrote: On Tue, Nov 21, 2017 at 12:17 AM, Hans Verkuil wrote: If the device tree for a board did not specify a cec clock, then adv7511_cec_init would return an error, which would cause adv7511_probe() to fail and thus there is no HDMI output. There is no

Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-22 Thread John Stultz
On Tue, Nov 21, 2017 at 12:17 AM, Hans Verkuil wrote: > If the device tree for a board did not specify a cec clock, then > adv7511_cec_init would return an error, which would cause adv7511_probe() > to fail and thus there is no HDMI output. > > There is no need to have

Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-22 Thread John Stultz
On Tue, Nov 21, 2017 at 12:17 AM, Hans Verkuil wrote: > If the device tree for a board did not specify a cec clock, then > adv7511_cec_init would return an error, which would cause adv7511_probe() > to fail and thus there is no HDMI output. > > There is no need to have adv7511_probe() fail if the

Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-21 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday, 21 November 2017 10:17:43 EET Hans Verkuil wrote: > If the device tree for a board did not specify a cec clock, then > adv7511_cec_init would return an error, which would cause adv7511_probe() > to fail and thus there is no HDMI output. > > There is

Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-21 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday, 21 November 2017 10:17:43 EET Hans Verkuil wrote: > If the device tree for a board did not specify a cec clock, then > adv7511_cec_init would return an error, which would cause adv7511_probe() > to fail and thus there is no HDMI output. > > There is

[PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-21 Thread Hans Verkuil
If the device tree for a board did not specify a cec clock, then adv7511_cec_init would return an error, which would cause adv7511_probe() to fail and thus there is no HDMI output. There is no need to have adv7511_probe() fail if the CEC initialization fails, so just change adv7511_cec_init() to

[PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-21 Thread Hans Verkuil
If the device tree for a board did not specify a cec clock, then adv7511_cec_init would return an error, which would cause adv7511_probe() to fail and thus there is no HDMI output. There is no need to have adv7511_probe() fail if the CEC initialization fails, so just change adv7511_cec_init() to