Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Dmitry Vyukov
On Fri, Jun 17, 2016 at 5:48 PM, Mark Rutland wrote: > On Fri, Jun 17, 2016 at 08:42:28AM -0700, Kees Cook wrote: >> On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: >> > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat >> >

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Dmitry Vyukov
On Fri, Jun 17, 2016 at 5:48 PM, Mark Rutland wrote: > On Fri, Jun 17, 2016 at 08:42:28AM -0700, Kees Cook wrote: >> On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: >> > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat >> > this option from CFLAGS_KCOV, and build the

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Mark Rutland
On Fri, Jun 17, 2016 at 05:46:38PM +0200, Alexander Potapenko wrote: > On Fri, Jun 17, 2016 at 5:42 PM, Kees Cook wrote: > > On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: > >> If the toolchain does not support -fsanitize-coverage=trace-pc, we

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Mark Rutland
On Fri, Jun 17, 2016 at 05:46:38PM +0200, Alexander Potapenko wrote: > On Fri, Jun 17, 2016 at 5:42 PM, Kees Cook wrote: > > On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: > >> If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > >> this option from CFLAGS_KCOV, and

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Alexander Potapenko
On Fri, Jun 17, 2016 at 5:42 PM, Kees Cook wrote: > On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: >> If the toolchain does not support -fsanitize-coverage=trace-pc, we blat >> this option from CFLAGS_KCOV, and build the kernel without >>

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Alexander Potapenko
On Fri, Jun 17, 2016 at 5:42 PM, Kees Cook wrote: > On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: >> If the toolchain does not support -fsanitize-coverage=trace-pc, we blat >> this option from CFLAGS_KCOV, and build the kernel without >> instrumentation, even if CONFIG_KCOV was selected.

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Mark Rutland
On Fri, Jun 17, 2016 at 08:42:28AM -0700, Kees Cook wrote: > On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: > > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > > this option from CFLAGS_KCOV, and build the kernel without > > instrumentation,

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Mark Rutland
On Fri, Jun 17, 2016 at 08:42:28AM -0700, Kees Cook wrote: > On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: > > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > > this option from CFLAGS_KCOV, and build the kernel without > > instrumentation, even if CONFIG_KCOV was

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Kees Cook
On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > this option from CFLAGS_KCOV, and build the kernel without > instrumentation, even if CONFIG_KCOV was selected. However, we still > build the rest

Re: [PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Kees Cook
On Fri, Jun 17, 2016 at 2:39 AM, Mark Rutland wrote: > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > this option from CFLAGS_KCOV, and build the kernel without > instrumentation, even if CONFIG_KCOV was selected. However, we still > build the rest of the kcov

[PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Mark Rutland
If the toolchain does not support -fsanitize-coverage=trace-pc, we blat this option from CFLAGS_KCOV, and build the kernel without instrumentation, even if CONFIG_KCOV was selected. However, we still build the rest of the kcov infrastructure, and expose a kcov file under debugfs. This can be

[PATCHv3] kcov: reject open when kernel not instrumented

2016-06-17 Thread Mark Rutland
If the toolchain does not support -fsanitize-coverage=trace-pc, we blat this option from CFLAGS_KCOV, and build the kernel without instrumentation, even if CONFIG_KCOV was selected. However, we still build the rest of the kcov infrastructure, and expose a kcov file under debugfs. This can be