Re: [PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-29 Thread J. Bruce Fields
On Fri, Jul 27, 2012 at 04:45:52PM -0400, J. Bruce Fields wrote: > On Fri, Jul 27, 2012 at 12:42:52AM -0400, Filipe Brandenburger wrote: > > When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], > > the custom signal or owner (if any were previously set using F_SETSIG > > or

Re: [PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-29 Thread J. Bruce Fields
On Fri, Jul 27, 2012 at 04:45:52PM -0400, J. Bruce Fields wrote: On Fri, Jul 27, 2012 at 12:42:52AM -0400, Filipe Brandenburger wrote: When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], the custom signal or owner (if any were previously set using F_SETSIG or F_SETOWN

Re: [PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-27 Thread J. Bruce Fields
On Fri, Jul 27, 2012 at 12:42:52AM -0400, Filipe Brandenburger wrote: > When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], > the custom signal or owner (if any were previously set using F_SETSIG > or F_SETOWN fcntls) would be reset when F_SETLEASE was called for the > second

Re: [PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-27 Thread J. Bruce Fields
On Fri, Jul 27, 2012 at 12:42:52AM -0400, Filipe Brandenburger wrote: When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], the custom signal or owner (if any were previously set using F_SETSIG or F_SETOWN fcntls) would be reset when F_SETLEASE was called for the second time

[PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-26 Thread Filipe Brandenburger
When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], the custom signal or owner (if any were previously set using F_SETSIG or F_SETOWN fcntls) would be reset when F_SETLEASE was called for the second time on the same file descriptor. This bug is a regression of 2.6.37 and is

[PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-26 Thread Filipe Brandenburger
When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], the custom signal or owner (if any were previously set using F_SETSIG or F_SETOWN fcntls) would be reset when F_SETLEASE was called for the second time on the same file descriptor. This bug is a regression of 2.6.37 and is