Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-18 Thread Greg Kroah-Hartman
On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote: > Signed-off-by: Raphaël Beamonte You can't submit a patch with no changelog information, sorry. Always build your patches, otherwise you make maintainers really grumpy as it breaks their build. greg k-h -- To unsubscribe from

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-18 Thread Sudip Mukherjee
On Tue, Aug 18, 2015 at 01:27:31AM -0400, Raphaël Beamonte wrote: > 2015-08-18 0:24 GMT-04:00 Sudip Mukherjee : > >> + netdev_err("[Sendconfigpkt]Get Timed out\n"); > > This will not compile. you can not just replace printk with > > netdev_*, you need to mention a

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-18 Thread Sudip Mukherjee
On Tue, Aug 18, 2015 at 01:27:31AM -0400, Raphaël Beamonte wrote: 2015-08-18 0:24 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com: + netdev_err([Sendconfigpkt]Get Timed out\n); This will not compile. you can not just replace printk with netdev_*, you need to

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-18 Thread Greg Kroah-Hartman
On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote: Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com You can't submit a patch with no changelog information, sorry. Always build your patches, otherwise you make maintainers really grumpy as it breaks their build. greg k-h

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Raphaël Beamonte
2015-08-18 0:24 GMT-04:00 Sudip Mukherjee : >> + netdev_err("[Sendconfigpkt]Get Timed out\n"); > This will not compile. you can not just replace printk with > netdev_*, you need to mention a net_device. You're right! I'm making a lot of mistakes. It seems I called the

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Sudip Mukherjee
On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote: > Signed-off-by: Raphaël Beamonte > --- > drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- > drivers/staging/wilc1000/linux_wlan.c| 8 > drivers/staging/wilc1000/linux_wlan_common.h | 28 >

[PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Raphaël Beamonte
Signed-off-by: Raphaël Beamonte --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c| 8 drivers/staging/wilc1000/linux_wlan_common.h | 28 ++-- drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-

[PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Raphaël Beamonte
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c| 8 drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Sudip Mukherjee
On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote: Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c| 8 drivers/staging/wilc1000/linux_wlan_common.h |

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Raphaël Beamonte
2015-08-18 0:24 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com: + netdev_err([Sendconfigpkt]Get Timed out\n); This will not compile. you can not just replace printk with netdev_*, you need to mention a net_device. You're right! I'm making a lot of mistakes. It