[NAK] Re: [PATCHv3 1/4] fs: Move core dump functionality into its own file

Hi Alex, Overall, this seems like a fine idea. However, I think the code move has gone very badly. Comments are mismatched, there are typos added, formatting changed, case changed, trailing white space added, and punctuation dropped. NAKed-by: Kees Cook On Sun, Aug 05, 2012 at 04:18:38AM

[PATCHv3 1/4] fs: Move core dump functionality into its own file

This prepares for making core dump functionality optional. The variable "suid_dumpable" and associated functions are left in fs/exec.c because they're used elsewhere, such as in ptrace. Signed-off-by: Alex Kelly Reviewed-by: Josh Triplett --- v2: This patch set is a second revision that

[PATCHv3 1/4] fs: Move core dump functionality into its own file

This prepares for making core dump functionality optional. The variable suid_dumpable and associated functions are left in fs/exec.c because they're used elsewhere, such as in ptrace. Signed-off-by: Alex Kelly alex.page.ke...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org --- v2:

[NAK] Re: [PATCHv3 1/4] fs: Move core dump functionality into its own file

Hi Alex, Overall, this seems like a fine idea. However, I think the code move has gone very badly. Comments are mismatched, there are typos added, formatting changed, case changed, trailing white space added, and punctuation dropped. NAKed-by: Kees Cook keesc...@chromium.org On Sun, Aug 05,