Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Keith Busch
On Fri, Sep 23, 2016 at 02:12:23PM -0500, Bjorn Helgaas wrote: > BTW, the "Volume Management Device Driver" config item appears by > itself in the top-level menuconfig menu. That seems a little ... > presumptuous; is it what you intended? Not really intended, but I didn't really know any better

Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Keith Busch
On Fri, Sep 23, 2016 at 02:12:23PM -0500, Bjorn Helgaas wrote: > BTW, the "Volume Management Device Driver" config item appears by > itself in the top-level menuconfig menu. That seems a little ... > presumptuous; is it what you intended? Not really intended, but I didn't really know any better

Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Bjorn Helgaas
On Fri, Sep 23, 2016 at 12:57:02PM -0400, Keith Busch wrote: > On Fri, Sep 23, 2016 at 09:34:41AM -0500, Bjorn Helgaas wrote: > > I made the necessary changes to match the renaming I did in the first > > patch, and I also used plain old "#ifdef" instead of "#if IS_ENABLED" > > since the rest of

Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Bjorn Helgaas
On Fri, Sep 23, 2016 at 12:57:02PM -0400, Keith Busch wrote: > On Fri, Sep 23, 2016 at 09:34:41AM -0500, Bjorn Helgaas wrote: > > I made the necessary changes to match the renaming I did in the first > > patch, and I also used plain old "#ifdef" instead of "#if IS_ENABLED" > > since the rest of

Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Keith Busch
On Fri, Sep 23, 2016 at 09:34:41AM -0500, Bjorn Helgaas wrote: > I made the necessary changes to match the renaming I did in the first > patch, and I also used plain old "#ifdef" instead of "#if IS_ENABLED" > since the rest of the file uses the former style. If there's a reason > to switch, we

Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Keith Busch
On Fri, Sep 23, 2016 at 09:34:41AM -0500, Bjorn Helgaas wrote: > I made the necessary changes to match the renaming I did in the first > patch, and I also used plain old "#ifdef" instead of "#if IS_ENABLED" > since the rest of the file uses the former style. If there's a reason > to switch, we

Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Bjorn Helgaas
On Tue, Sep 13, 2016 at 09:05:40AM -0600, Keith Busch wrote: > This patch adds a new function to set PCI domain specific options as > devices are added. The usage included in this patch is for LED indicator > control in VMD domains, but may be extended in the future as new domain > specific

Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-23 Thread Bjorn Helgaas
On Tue, Sep 13, 2016 at 09:05:40AM -0600, Keith Busch wrote: > This patch adds a new function to set PCI domain specific options as > devices are added. The usage included in this patch is for LED indicator > control in VMD domains, but may be extended in the future as new domain > specific

[PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-13 Thread Keith Busch
This patch adds a new function to set PCI domain specific options as devices are added. The usage included in this patch is for LED indicator control in VMD domains, but may be extended in the future as new domain specific options are required. PCIe LED Slot Control in a VMD domain is repurposed

[PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

2016-09-13 Thread Keith Busch
This patch adds a new function to set PCI domain specific options as devices are added. The usage included in this patch is for LED indicator control in VMD domains, but may be extended in the future as new domain specific options are required. PCIe LED Slot Control in a VMD domain is repurposed