Re: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-05 Thread Jakub Kicinski
On Tue, 5 Jul 2016 10:56:13 +, David Laight wrote: > From: Jakub Kicinski > > Sent: 01 July 2016 22:27 > > > > C bitfields are problematic and best avoided. Developers > > interacting with hardware registers find themselves searching > > for easy-to-use alternatives. Common approach is to

Re: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-05 Thread Jakub Kicinski
On Tue, 5 Jul 2016 10:56:13 +, David Laight wrote: > From: Jakub Kicinski > > Sent: 01 July 2016 22:27 > > > > C bitfields are problematic and best avoided. Developers > > interacting with hardware registers find themselves searching > > for easy-to-use alternatives. Common approach is to

RE: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-05 Thread David Laight
From: Jakub Kicinski > Sent: 01 July 2016 22:27 > > C bitfields are problematic and best avoided. Developers > interacting with hardware registers find themselves searching > for easy-to-use alternatives. Common approach is to define > structures or sets of macros containing mask and shift

RE: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-05 Thread David Laight
From: Jakub Kicinski > Sent: 01 July 2016 22:27 > > C bitfields are problematic and best avoided. Developers > interacting with hardware registers find themselves searching > for easy-to-use alternatives. Common approach is to define > structures or sets of macros containing mask and shift

Re: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-03 Thread Hannes Frederic Sowa
On 01.07.2016 23:26, Jakub Kicinski wrote: > C bitfields are problematic and best avoided. Developers > interacting with hardware registers find themselves searching > for easy-to-use alternatives. Common approach is to define > structures or sets of macros containing mask and shift pair. >

Re: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-03 Thread Hannes Frederic Sowa
On 01.07.2016 23:26, Jakub Kicinski wrote: > C bitfields are problematic and best avoided. Developers > interacting with hardware registers find themselves searching > for easy-to-use alternatives. Common approach is to define > structures or sets of macros containing mask and shift pair. >

[PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-01 Thread Jakub Kicinski
C bitfields are problematic and best avoided. Developers interacting with hardware registers find themselves searching for easy-to-use alternatives. Common approach is to define structures or sets of macros containing mask and shift pair. Operations on the register are then performed as follows:

[PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-01 Thread Jakub Kicinski
C bitfields are problematic and best avoided. Developers interacting with hardware registers find themselves searching for easy-to-use alternatives. Common approach is to define structures or sets of macros containing mask and shift pair. Operations on the register are then performed as follows: