Re: [PATCHv4] uprobes: simplify rip-relative handling

2014-05-01 Thread Jim Keniston
On Thu, 2014-05-01 at 20:50 +0200, Oleg Nesterov wrote: > Thanks, I hope that Jim's ack still applies to this version. Yes. v4 looks fine, although Oleg has a good point about moving the comment. But I'd move more of the comment, starting with * We have to fix things up as follows:

Re: [PATCHv4] uprobes: simplify rip-relative handling

2014-05-01 Thread Oleg Nesterov
Thanks, I hope that Jim's ack still applies to this version. On 05/01, Denys Vlasenko wrote: > > v4: Changed arch_uprobe_xol_was_trapped() comment to reflect new logic. Hmm. I guess you meant arch_uprobe_post_xol()... please see below. > static int default_post_xol_op(struct arch_uprobe

[PATCHv4] uprobes: simplify rip-relative handling

2014-05-01 Thread Denys Vlasenko
It is possible to replace rip-relative addressing mode with addressing mode of the same length: (reg+disp32). This eliminates the need to fix up immediate and correct for changing instruction length. v2: Rebased on top of Oleg's latest changes and run-tested. v3: Removed unnecessary cast.

[PATCHv4] uprobes: simplify rip-relative handling

2014-05-01 Thread Denys Vlasenko
It is possible to replace rip-relative addressing mode with addressing mode of the same length: (reg+disp32). This eliminates the need to fix up immediate and correct for changing instruction length. v2: Rebased on top of Oleg's latest changes and run-tested. v3: Removed unnecessary cast.

Re: [PATCHv4] uprobes: simplify rip-relative handling

2014-05-01 Thread Oleg Nesterov
Thanks, I hope that Jim's ack still applies to this version. On 05/01, Denys Vlasenko wrote: v4: Changed arch_uprobe_xol_was_trapped() comment to reflect new logic. Hmm. I guess you meant arch_uprobe_post_xol()... please see below. static int default_post_xol_op(struct arch_uprobe *auprobe,

Re: [PATCHv4] uprobes: simplify rip-relative handling

2014-05-01 Thread Jim Keniston
On Thu, 2014-05-01 at 20:50 +0200, Oleg Nesterov wrote: Thanks, I hope that Jim's ack still applies to this version. Yes. v4 looks fine, although Oleg has a good point about moving the comment. But I'd move more of the comment, starting with * We have to fix things up as follows: