> Since there is no legacy interface to worry about all members added to
> the structure can and should be neutral of the word size.
OK, perhaps add a giant comment warning about that. History tells us
that people will get it wrong.
> We've done
> this with some syscalls already (like pread64)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Zach Brown wrote:
> Have you given thought to having to perform compat translation on this?
> Today it's only copied directly from the user pointer into the union
> in the task_struct.
Since there is no legacy interface to worry about all members
> +union indirect_params {
> + struct {
> +int flags;
> + } file_flags;
> +};
Have you given thought to having to perform compat translation on this?
Today it's only copied directly from the user pointer into the union
in the task_struct.
I'd love if we could only use fixed-width fields
+union indirect_params {
+ struct {
+int flags;
+ } file_flags;
+};
Have you given thought to having to perform compat translation on this?
Today it's only copied directly from the user pointer into the union
in the task_struct.
I'd love if we could only use fixed-width fields in
Since there is no legacy interface to worry about all members added to
the structure can and should be neutral of the word size.
OK, perhaps add a giant comment warning about that. History tells us
that people will get it wrong.
We've done
this with some syscalls already (like pread64)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Zach Brown wrote:
Have you given thought to having to perform compat translation on this?
Today it's only copied directly from the user pointer into the union
in the task_struct.
Since there is no legacy interface to worry about all members
This is a first user of sys_indirect. Several of the socket-related system
calls which produce a file handle now can be passed an additional parameter
to set the FD_CLOEXEC flag.
arch/x86/ia32/Makefile|1 +
arch/x86/ia32/sys_ia32.c |4
include/asm-x86/ia32_unistd.h |
This is a first user of sys_indirect. Several of the socket-related system
calls which produce a file handle now can be passed an additional parameter
to set the FD_CLOEXEC flag.
arch/x86/ia32/Makefile|1 +
arch/x86/ia32/sys_ia32.c |4
include/asm-x86/ia32_unistd.h |
8 matches
Mail list logo
