Re: [PATCHv5 2/7] of: Remove duplicated code for validating property and value

2013-04-03 Thread Rob Herring
On 04/03/2013 01:24 AM, Tony Prisk wrote: > Several functions in of/base.c have the same code duplicated for > finding and validating a property and value. > > struct property *prop = of_find_property(np, propname, NULL); > if (!prop) > return -EINVAL; > if (!prop->value) > return -ENO

[PATCHv5 2/7] of: Remove duplicated code for validating property and value

2013-04-02 Thread Tony Prisk
Several functions in of/base.c have the same code duplicated for finding and validating a property and value. struct property *prop = of_find_property(np, propname, NULL); if (!prop) return -EINVAL; if (!prop->value) return -ENODATA; if ( > prop->length) return -EOVERFLOW;