Re: [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling

2020-06-09 Thread Ritesh Harjani
On 6/9/20 3:50 PM, Borislav Petkov wrote: On Wed, Jun 03, 2020 at 03:40:16PM +0530, Ritesh Harjani wrote: Yes, this is being discussed in the community. I have submitted a patch which should help fix this warning msg. Feel free to give this a try on your setup. https://marc.info/?l=linux-ext

Re: [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling

2020-06-09 Thread Borislav Petkov
On Wed, Jun 03, 2020 at 03:40:16PM +0530, Ritesh Harjani wrote: > Yes, this is being discussed in the community. > I have submitted a patch which should help fix this warning msg. > Feel free to give this a try on your setup. > > https://marc.info/?l=linux-ext4&m=159110574414645&w=2 I just trigge

Re: [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling

2020-06-03 Thread Ritesh Harjani
Hi Marek, On 6/3/20 12:18 PM, Marek Szyprowski wrote: Hi Ritesh, On 20.05.2020 08:40, Ritesh Harjani wrote: There could be a race in function ext4_mb_discard_group_preallocations() where the 1st thread may iterate through group's bb_prealloc_list and remove all the PAs and add to function's lo

Re: [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling

2020-06-02 Thread Marek Szyprowski
Hi Ritesh, On 20.05.2020 08:40, Ritesh Harjani wrote: > There could be a race in function ext4_mb_discard_group_preallocations() > where the 1st thread may iterate through group's bb_prealloc_list and > remove all the PAs and add to function's local list head. > Now if the 2nd thread comes in to d

[PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling

2020-05-19 Thread Ritesh Harjani
There could be a race in function ext4_mb_discard_group_preallocations() where the 1st thread may iterate through group's bb_prealloc_list and remove all the PAs and add to function's local list head. Now if the 2nd thread comes in to discard the group preallocations, it will see that the group->bb