Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-22 Thread Brian Norris
Hi Michael, On Tue, Jul 22, 2014 at 12:09:54PM +0200, Michael Grzeschik wrote: > I think your hints all make sense. I was poking around with the > functions we have and need to asign. Unfortunetly I ran into no clear > picture to fix it the correct way and came up with this hacky patch. Your

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-22 Thread Michael Grzeschik
Hi Brian, On Mon, Jul 14, 2014 at 12:19:47PM -0700, Brian Norris wrote: > Hi Michael, > > On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: > > The current approach of the read_page function is to iterate over all > > subpages and call the correct_data function. The correct_data

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-22 Thread Michael Grzeschik
Hi Brian, On Mon, Jul 14, 2014 at 12:19:47PM -0700, Brian Norris wrote: Hi Michael, On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: The current approach of the read_page function is to iterate over all subpages and call the correct_data function. The correct_data

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-22 Thread Brian Norris
Hi Michael, On Tue, Jul 22, 2014 at 12:09:54PM +0200, Michael Grzeschik wrote: I think your hints all make sense. I was poking around with the functions we have and need to asign. Unfortunetly I ran into no clear picture to fix it the correct way and came up with this hacky patch. Your patch

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-14 Thread Brian Norris
Hi Michael, On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: > The current approach of the read_page function is to iterate over all > subpages and call the correct_data function. The correct_data function > currently does the same. It iterates over all subpages and checks for >

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-14 Thread Michael Grzeschik
@David: Ping! Some comments on this patch would probably help to get it mainline. :) Regards, Michael On Sat, Jul 05, 2014 at 04:45:21PM +0200, Michael Grzeschik wrote: > Ping! > > On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: > > The current approach of the read_page

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-14 Thread Michael Grzeschik
@David: Ping! Some comments on this patch would probably help to get it mainline. :) Regards, Michael On Sat, Jul 05, 2014 at 04:45:21PM +0200, Michael Grzeschik wrote: Ping! On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: The current approach of the read_page function

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-14 Thread Brian Norris
Hi Michael, On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: The current approach of the read_page function is to iterate over all subpages and call the correct_data function. The correct_data function currently does the same. It iterates over all subpages and checks for

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-05 Thread Michael Grzeschik
Ping! On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: > The current approach of the read_page function is to iterate over all > subpages and call the correct_data function. The correct_data function > currently does the same. It iterates over all subpages and checks for >

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-05 Thread Michael Grzeschik
Ping! On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: The current approach of the read_page function is to iterate over all subpages and call the correct_data function. The correct_data function currently does the same. It iterates over all subpages and checks for

[PATH v2] mxc_nand: use our own read_page function

2014-06-27 Thread Michael Grzeschik
The current approach of the read_page function is to iterate over all subpages and call the correct_data function. The correct_data function currently does the same. It iterates over all subpages and checks for correctable and uncorrectable data. This redundant call for each subpage leads to

[PATH v2] mxc_nand: use our own read_page function

2014-06-27 Thread Michael Grzeschik
The current approach of the read_page function is to iterate over all subpages and call the correct_data function. The correct_data function currently does the same. It iterates over all subpages and checks for correctable and uncorrectable data. This redundant call for each subpage leads to