Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-13 Thread WANG Cong
On Fri, Jan 11, 2008 at 06:02:04PM +0100, Sam Ravnborg wrote: >On Fri, Jan 11, 2008 at 02:17:54PM +, Ralf Baechle wrote: >> On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote: >> >> > >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? >> > >It would be better to use $(LINUXIN

Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-11 Thread Sam Ravnborg
On Fri, Jan 11, 2008 at 02:17:54PM +, Ralf Baechle wrote: > On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote: > > > >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? > > >It would be better to use $(LINUXINCLUDE) as we then pull in all config > > >symbols too and do not ha

Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-11 Thread Ralf Baechle
On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote: > >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? > >It would be better to use $(LINUXINCLUDE) as we then pull in all config > >symbols too and do not have to hardcode kbuild internal names (include2). > > OK. Refine this pa

Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-02 Thread Sam Ravnborg
On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote: > > >> > >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? > >It would be better to use $(LINUXINCLUDE) as we then pull in all config > >symbols too and do not have to hardcode kbuild internal names (include2). > > OK. Refine

(Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
>> >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? >It would be better to use $(LINUXINCLUDE) as we then pull in all config >symbols too and do not have to hardcode kbuild internal names (include2). OK. Refine this patch. ---> Since TOPDIR is obsolete, this patch removes

Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread Sam Ravnborg
On Tue, Jan 01, 2008 at 02:44:48PM +0100, Andreas Schwab wrote: > Sam Ravnborg <[EMAIL PROTECTED]> writes: > > >> @@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \ > >>-D TIMESTAMP=$(shell date +%s) > >> > >> $(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE) > >> - $

Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread Andreas Schwab
Sam Ravnborg <[EMAIL PROTECTED]> writes: >> @@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \ >> -D TIMESTAMP=$(shell date +%s) >> >> $(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE) >> -$(CC) -fno-pic $(HEAD_DEFINES) -I$(TOPDIR)/include -c -o $@ $< >> +$(CC

(Try #2) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
>> -KERNEL_IMAGE = $(TOPDIR)/vmlinux >> +KERNEL_IMAGE = $(objtree)/vmlinux > >Current directory when building is $(objtree) so here we should >just skip the use of TOPDIR like this: >> +KERNEL_IMAGE = vmlinux > > >> KERNEL_START = $(shell $(NM) $(KERNEL_IMAGE) | grep " _text" | cut -f1 -d\ ) >>

Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread Sam Ravnborg
On Tue, Jan 01, 2008 at 03:22:38PM +0800, WANG Cong wrote: > > TOPDIR is obsolete, use objtree instead. > This patch removes TOPDIR from all Mips Makefiles. > > Cc: Ralf Baechle <[EMAIL PROTECTED]> > Cc: Sam Ravnborg <[EMAIL PROTECTED]> > Signed-off-by: WANG Cong <[EMAIL PROTECTED]> > > --- > >

[Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all Mips Makefiles. Cc: Ralf Baechle <[EMAIL PROTECTED]> Cc: Sam Ravnborg <[EMAIL PROTECTED]> Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- diff --git a/arch/mips/lasat/image/Makefile b/arch/mips/lasat/image/Makefile ind