Hi,
On 08/17/2012 04:27 PM, Alan Stern wrote:
On Fri, 17 Aug 2012, Alan Stern wrote:
On Fri, 17 Aug 2012, Hans de Goede wrote:
No my patch was a hack to undo the results of the commit causing
the regression in the IDE case. But Alan's approach clearly is
much better! Once we are sure
On Fri, 17 Aug 2012, Alan Stern wrote:
> On Fri, 17 Aug 2012, Hans de Goede wrote:
>
> > No my patch was a hack to undo the results of the commit causing
> > the regression in the IDE case. But Alan's approach clearly is
> > much better! Once we are sure drvdata is not used anywhere the
> >
On Fri, 17 Aug 2012, Hans de Goede wrote:
> No my patch was a hack to undo the results of the commit causing
> the regression in the IDE case. But Alan's approach clearly is
> much better! Once we are sure drvdata is not used anywhere the
> dev_set_drvdata call could be removed in the place where
Hi all,
On 08/16/2012 10:02 PM, Rafael J. Wysocki wrote:
On Thursday, August 16, 2012, Alan Stern wrote:
On Thu, 16 Aug 2012, Miklos Szeredi wrote:
Yes, this appears to work. Following patch fixes the suspend oops.
Thanks,
Miklos
OK
Miklos, can you please send that to Dave with a proper
Hi all,
On 08/16/2012 10:02 PM, Rafael J. Wysocki wrote:
On Thursday, August 16, 2012, Alan Stern wrote:
On Thu, 16 Aug 2012, Miklos Szeredi wrote:
Yes, this appears to work. Following patch fixes the suspend oops.
Thanks,
Miklos
OK
Miklos, can you please send that to Dave with a proper
On Fri, 17 Aug 2012, Hans de Goede wrote:
No my patch was a hack to undo the results of the commit causing
the regression in the IDE case. But Alan's approach clearly is
much better! Once we are sure drvdata is not used anywhere the
dev_set_drvdata call could be removed in the place where my
On Fri, 17 Aug 2012, Alan Stern wrote:
On Fri, 17 Aug 2012, Hans de Goede wrote:
No my patch was a hack to undo the results of the commit causing
the regression in the IDE case. But Alan's approach clearly is
much better! Once we are sure drvdata is not used anywhere the
Hi,
On 08/17/2012 04:27 PM, Alan Stern wrote:
On Fri, 17 Aug 2012, Alan Stern wrote:
On Fri, 17 Aug 2012, Hans de Goede wrote:
No my patch was a hack to undo the results of the commit causing
the regression in the IDE case. But Alan's approach clearly is
much better! Once we are sure
On Thursday, August 16, 2012, Alan Stern wrote:
> On Thu, 16 Aug 2012, Miklos Szeredi wrote:
>
> > Yes, this appears to work. Following patch fixes the suspend oops.
> >
> > Thanks,
> > Miklos
OK
Miklos, can you please send that to Dave with a proper changelog and
sign-off (please add my ACK
On Thu, 16 Aug 2012, Miklos Szeredi wrote:
> Yes, this appears to work. Following patch fixes the suspend oops.
>
> Thanks,
> Miklos
>
> ---
> drivers/ide/ide-pm.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c
>
Alan Stern writes:
> On Thu, 16 Aug 2012, Hans de Goede wrote:
>
>> Ah right, these are bus_driver operations. That explains some things, so I've
>> done some more research asking myself: "Why does generic_ide_suspend(), which
>> is a *bus* op, call dev_get_drvdata?", the answer to that seems to
On Thu, 16 Aug 2012, Hans de Goede wrote:
> Ah right, these are bus_driver operations. That explains some things, so I've
> done some more research asking myself: "Why does generic_ide_suspend(), which
> is a *bus* op, call dev_get_drvdata?", the answer to that seems to be that
> the ide
Hi,
On 08/15/2012 09:59 PM, Rafael J. Wysocki wrote:
On Wednesday, August 15, 2012, Hans de Goede wrote:
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev->p->driver_data == NULL) and this function is not
Hi,
On 08/15/2012 09:59 PM, Rafael J. Wysocki wrote:
On Wednesday, August 15, 2012, Hans de Goede wrote:
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev-p-driver_data == NULL) and this function is not
On Thu, 16 Aug 2012, Hans de Goede wrote:
Ah right, these are bus_driver operations. That explains some things, so I've
done some more research asking myself: Why does generic_ide_suspend(), which
is a *bus* op, call dev_get_drvdata?, the answer to that seems to be that
the ide subsystem is
Alan Stern st...@rowland.harvard.edu writes:
On Thu, 16 Aug 2012, Hans de Goede wrote:
Ah right, these are bus_driver operations. That explains some things, so I've
done some more research asking myself: Why does generic_ide_suspend(), which
is a *bus* op, call dev_get_drvdata?, the answer
On Thu, 16 Aug 2012, Miklos Szeredi wrote:
Yes, this appears to work. Following patch fixes the suspend oops.
Thanks,
Miklos
---
drivers/ide/ide-pm.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c
index
On Thursday, August 16, 2012, Alan Stern wrote:
On Thu, 16 Aug 2012, Miklos Szeredi wrote:
Yes, this appears to work. Following patch fixes the suspend oops.
Thanks,
Miklos
OK
Miklos, can you please send that to Dave with a proper changelog and
sign-off (please add my ACK too)?
On Wednesday, August 15, 2012, Hans de Goede wrote:
> Hi,
>
> On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
> > Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
> > returns NULL (dev->p->driver_data == NULL) and this function is not
> > prepared for this.
> >
> > I bisected it to
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev->p->driver_data == NULL) and this function is not
prepared for this.
I bisected it to 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound).
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev-p-driver_data == NULL) and this function is not
prepared for this.
I bisected it to 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound).
On Wednesday, August 15, 2012, Hans de Goede wrote:
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev-p-driver_data == NULL) and this function is not
prepared for this.
I bisected it to 0998d063
22 matches
Mail list logo
