Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-04 Thread Daniel Vetter
On Mon, Aug 03, 2015 at 12:25:11PM -0400, Theodore Ts'o wrote: > On Mon, Aug 03, 2015 at 05:27:29PM +0200, Daniel Vetter wrote: > > > > Ok I updated fixes-stuff with just 2 patches which seem to be enough to > > fix it. Plus a patch to convert Linus' hack into something we can keep > > plus a

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-04 Thread Daniel Vetter
On Mon, Aug 03, 2015 at 12:25:11PM -0400, Theodore Ts'o wrote: On Mon, Aug 03, 2015 at 05:27:29PM +0200, Daniel Vetter wrote: Ok I updated fixes-stuff with just 2 patches which seem to be enough to fix it. Plus a patch to convert Linus' hack into something we can keep plus a drive-by

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Rafael J. Wysocki
On Tuesday, August 04, 2015 12:05:14 AM Daniel Vetter wrote: > On Mon, Aug 3, 2015 at 7:24 PM, Linus Torvalds > wrote: > >> However, I'm > >> still seeing a large number of drm/i915 related warning messages and > >> other kernel kvetching. > > > > I suspect I can live with

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Daniel Vetter
On Mon, Aug 3, 2015 at 7:24 PM, Linus Torvalds wrote: >> However, I'm >> still seeing a large number of drm/i915 related warning messages and >> other kernel kvetching. > > I suspect I can live with that for now. The lockdep one looks like > it's mainly an initialization

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Theodore Ts'o
On Mon, Aug 03, 2015 at 10:24:53AM -0700, Linus Torvalds wrote: > On Mon, Aug 3, 2015 at 9:25 AM, Theodore Ts'o wrote: > > > > I've just tried pulling in your updated fixes-stuff, and it avoids the > > oops and allows external the monitor to work correctly. > > Good. Have either of you tested

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Linus Torvalds
On Mon, Aug 3, 2015 at 9:25 AM, Theodore Ts'o wrote: > > I've just tried pulling in your updated fixes-stuff, and it avoids the > oops and allows external the monitor to work correctly. Good. Have either of you tested the suspend/resume behavior? Is that fixed too? >

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Theodore Ts'o
On Mon, Aug 03, 2015 at 05:27:29PM +0200, Daniel Vetter wrote: > > Ok I updated fixes-stuff with just 2 patches which seem to be enough to > fix it. Plus a patch to convert Linus' hack into something we can keep > plus a drive-by WARNING fix in mst that got in the way for me. > > Seems to work

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Daniel Vetter
On Thu, Jul 30, 2015 at 11:50:29AM -0400, Theodore Ts'o wrote: > On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: > > I have 4 patches in git://people.freedesktop.org/~danvet/drm fixes-stuff > > but I couldn't test them yet since no dp mst here and I didn't find > > anything that

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Daniel Vetter
On Thu, Jul 30, 2015 at 11:50:29AM -0400, Theodore Ts'o wrote: On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: I have 4 patches in git://people.freedesktop.org/~danvet/drm fixes-stuff but I couldn't test them yet since no dp mst here and I didn't find anything that would ship

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Theodore Ts'o
On Mon, Aug 03, 2015 at 05:27:29PM +0200, Daniel Vetter wrote: Ok I updated fixes-stuff with just 2 patches which seem to be enough to fix it. Plus a patch to convert Linus' hack into something we can keep plus a drive-by WARNING fix in mst that got in the way for me. Seems to work here in

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Rafael J. Wysocki
On Tuesday, August 04, 2015 12:05:14 AM Daniel Vetter wrote: On Mon, Aug 3, 2015 at 7:24 PM, Linus Torvalds torva...@linux-foundation.org wrote: However, I'm still seeing a large number of drm/i915 related warning messages and other kernel kvetching. I suspect I

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Daniel Vetter
On Mon, Aug 3, 2015 at 7:24 PM, Linus Torvalds torva...@linux-foundation.org wrote: However, I'm still seeing a large number of drm/i915 related warning messages and other kernel kvetching. I suspect I can live with that for now. The lockdep one looks like it's mainly an

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Theodore Ts'o
On Mon, Aug 03, 2015 at 10:24:53AM -0700, Linus Torvalds wrote: On Mon, Aug 3, 2015 at 9:25 AM, Theodore Ts'o ty...@mit.edu wrote: I've just tried pulling in your updated fixes-stuff, and it avoids the oops and allows external the monitor to work correctly. Good. Have either of you

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-08-03 Thread Linus Torvalds
On Mon, Aug 3, 2015 at 9:25 AM, Theodore Ts'o ty...@mit.edu wrote: I've just tried pulling in your updated fixes-stuff, and it avoids the oops and allows external the monitor to work correctly. Good. Have either of you tested the suspend/resume behavior? Is that fixed too?

Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Linus Torvalds
On Thu, Jul 30, 2015 at 8:57 AM, Takashi Iwai wrote: > On Thu, 30 Jul 2015 17:32:28 +0200, > Theodore Ts'o wrote: >> >> BTW, is there any chance that I can suspend my laptop, and then move >> it from my docking station at home (where I have a Dell 30" display) >> to my docking station at work

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Daniel Vetter
On Thu, Jul 30, 2015 at 11:50:29AM -0400, Theodore Ts'o wrote: > On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: > > I have 4 patches in git://people.freedesktop.org/~danvet/drm fixes-stuff > > but I couldn't test them yet since no dp mst here and I didn't find > > anything that

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Theodore Ts'o
On Thu, Jul 30, 2015 at 11:50:29AM -0400, Theodore Ts'o wrote: > I've tried pulling in your patches from fixes-stuff, onto Linus's tree > (without Linus's fix), and the good news is that I'm no longer > crashing on boot. > > The *bad* news is that (a) it breaks the external monitor attached to >

Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Takashi Iwai
On Thu, 30 Jul 2015 17:32:28 +0200, Theodore Ts'o wrote: > > On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: > > On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: > > > drivers/gpu/drm/drm_atomic_helper.c | 8 +--- > > > 1 file changed, 5 insertions(+), 3

Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Daniel Vetter
On Thu, Jul 30, 2015 at 5:32 PM, Theodore Ts'o wrote: > On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: >> On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: >> > drivers/gpu/drm/drm_atomic_helper.c | 8 +--- >> > 1 file changed, 5 insertions(+), 3 deletions(-) >>

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Theodore Ts'o
On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: > I have 4 patches in git://people.freedesktop.org/~danvet/drm fixes-stuff > but I couldn't test them yet since no dp mst here and I didn't find > anything that would ship faster than 1-2 weeks yet. I'll try to get some > other people

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Theodore Ts'o
On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: > On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: > > drivers/gpu/drm/drm_atomic_helper.c | 8 +--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > >

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Daniel Vetter
On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: > drivers/gpu/drm/drm_atomic_helper.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index 5b59d5ad7d1c..aac212297b49

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Dave Airlie
On 30 July 2015 at 15:18, Linus Torvalds wrote: > On Wed, Jul 29, 2015 at 6:39 PM, Theodore Ts'o wrote: >> >> It's here: https://goo.gl/photos/xHjn2Z97JQEw6k2C9 > > You didn't catch enough of the code line to decode the code, but it's > early enough in drm_crtc_index() (just five bytes in) that

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Theodore Ts'o
On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: drivers/gpu/drm/drm_atomic_helper.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Daniel Vetter
On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: drivers/gpu/drm/drm_atomic_helper.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 5b59d5ad7d1c..aac212297b49 100644

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Daniel Vetter
On Thu, Jul 30, 2015 at 11:50:29AM -0400, Theodore Ts'o wrote: On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: I have 4 patches in git://people.freedesktop.org/~danvet/drm fixes-stuff but I couldn't test them yet since no dp mst here and I didn't find anything that would ship

Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Linus Torvalds
On Thu, Jul 30, 2015 at 8:57 AM, Takashi Iwai ti...@suse.de wrote: On Thu, 30 Jul 2015 17:32:28 +0200, Theodore Ts'o wrote: BTW, is there any chance that I can suspend my laptop, and then move it from my docking station at home (where I have a Dell 30 display) to my docking station at work

Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Takashi Iwai
On Thu, 30 Jul 2015 17:32:28 +0200, Theodore Ts'o wrote: On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: drivers/gpu/drm/drm_atomic_helper.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Theodore Ts'o
On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: I have 4 patches in git://people.freedesktop.org/~danvet/drm fixes-stuff but I couldn't test them yet since no dp mst here and I didn't find anything that would ship faster than 1-2 weeks yet. I'll try to get some other people here

Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Daniel Vetter
On Thu, Jul 30, 2015 at 5:32 PM, Theodore Ts'o ty...@mit.edu wrote: On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: drivers/gpu/drm/drm_atomic_helper.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Theodore Ts'o
On Thu, Jul 30, 2015 at 11:50:29AM -0400, Theodore Ts'o wrote: I've tried pulling in your patches from fixes-stuff, onto Linus's tree (without Linus's fix), and the good news is that I'm no longer crashing on boot. The *bad* news is that (a) it breaks the external monitor attached to the

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-30 Thread Dave Airlie
On 30 July 2015 at 15:18, Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Jul 29, 2015 at 6:39 PM, Theodore Ts'o ty...@mit.edu wrote: It's here: https://goo.gl/photos/xHjn2Z97JQEw6k2C9 You didn't catch enough of the code line to decode the code, but it's early enough in

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-29 Thread Linus Torvalds
On Wed, Jul 29, 2015 at 6:39 PM, Theodore Ts'o wrote: > > It's here: https://goo.gl/photos/xHjn2Z97JQEw6k2C9 You didn't catch enough of the code line to decode the code, but it's early enough in drm_crtc_index() (just five bytes in) that it's almost certainly the very first dereference, so it's

[REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-29 Thread Theodore Ts'o
On Wed, Jul 29, 2015 at 08:49:37PM -0400, Theodore Ts'o wrote: > > Unfortunately the failure causes a series of recursive faults and I > haven't been able to capture the stack trace, but on 4.2-rcX kernels, > I can reliably cause the system to crash if my T540p is booted with > the docking

[REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-29 Thread Theodore Ts'o
On Wed, Jul 29, 2015 at 08:49:37PM -0400, Theodore Ts'o wrote: Unfortunately the failure causes a series of recursive faults and I haven't been able to capture the stack trace, but on 4.2-rcX kernels, I can reliably cause the system to crash if my T540p is booted with the docking station

Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached

2015-07-29 Thread Linus Torvalds
On Wed, Jul 29, 2015 at 6:39 PM, Theodore Ts'o ty...@mit.edu wrote: It's here: https://goo.gl/photos/xHjn2Z97JQEw6k2C9 You didn't catch enough of the code line to decode the code, but it's early enough in drm_crtc_index() (just five bytes in) that it's almost certainly the very first