Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-24 Thread One Thousand Gnomes
On Wed, 24 Aug 2016 11:22:09 +0300 "Dan Akunis" wrote: > When select wakes up on a UDP socket, user is expecting to get data. Getting > 0 from recvfrom() or whatever read function she uses, is a wrong attitude. > I agree with David. > > The unit test that expects select

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-24 Thread One Thousand Gnomes
On Wed, 24 Aug 2016 11:22:09 +0300 "Dan Akunis" wrote: > When select wakes up on a UDP socket, user is expecting to get data. Getting > 0 from recvfrom() or whatever read function she uses, is a wrong attitude. > I agree with David. > > The unit test that expects select to wake up is wrong and

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 11:22 +0300, Dan Akunis wrote: > When select wakes up on a UDP socket, user is expecting to get data. Getting > 0 from recvfrom() or whatever read function she uses, is a wrong attitude. > I agree with David. > > The unit test that expects select to wake up is wrong and

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 11:22 +0300, Dan Akunis wrote: > When select wakes up on a UDP socket, user is expecting to get data. Getting > 0 from recvfrom() or whatever read function she uses, is a wrong attitude. > I agree with David. > > The unit test that expects select to wake up is wrong and

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-24 Thread Dan Akunis
with zero sized UDP packets From: Laura Abbott <labb...@redhat.com> Date: Tue, 23 Aug 2016 10:53:26 -0700 Fedora received a report[1] of a unit test failing on Ruby when using the 4.7 kernel. This was a test to send a zero sized UDP packet. With the 4.7 kernel, the test now timing out on a

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-24 Thread Dan Akunis
with zero sized UDP packets From: Laura Abbott Date: Tue, 23 Aug 2016 10:53:26 -0700 Fedora received a report[1] of a unit test failing on Ruby when using the 4.7 kernel. This was a test to send a zero sized UDP packet. With the 4.7 kernel, the test now timing out on a select instead

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Eric Dumazet
On Tue, 2016-08-23 at 13:06 -0700, Laura Abbott wrote: > > Fixes the test for me. You're welcome to take this as a Tested-by. Thanks Laura, I will submit an official patch immediately.

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Eric Dumazet
On Tue, 2016-08-23 at 13:06 -0700, Laura Abbott wrote: > > Fixes the test for me. You're welcome to take this as a Tested-by. Thanks Laura, I will submit an official patch immediately.

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Laura Abbott
On 08/23/2016 12:03 PM, Eric Dumazet wrote: On Tue, 2016-08-23 at 11:25 -0700, David Miller wrote: From: Laura Abbott Date: Tue, 23 Aug 2016 10:53:26 -0700 Fedora received a report[1] of a unit test failing on Ruby when using the 4.7 kernel. This was a test to send a zero

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Laura Abbott
On 08/23/2016 12:03 PM, Eric Dumazet wrote: On Tue, 2016-08-23 at 11:25 -0700, David Miller wrote: From: Laura Abbott Date: Tue, 23 Aug 2016 10:53:26 -0700 Fedora received a report[1] of a unit test failing on Ruby when using the 4.7 kernel. This was a test to send a zero sized UDP packet.

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Eric Dumazet
On Tue, 2016-08-23 at 11:25 -0700, David Miller wrote: > From: Laura Abbott > Date: Tue, 23 Aug 2016 10:53:26 -0700 > > > Fedora received a report[1] of a unit test failing on Ruby when using > > the > > 4.7 kernel. This was a test to send a zero sized UDP packet. With the >

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Eric Dumazet
On Tue, 2016-08-23 at 11:25 -0700, David Miller wrote: > From: Laura Abbott > Date: Tue, 23 Aug 2016 10:53:26 -0700 > > > Fedora received a report[1] of a unit test failing on Ruby when using > > the > > 4.7 kernel. This was a test to send a zero sized UDP packet. With the > > 4.7 kernel, the

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread David Miller
From: Laura Abbott Date: Tue, 23 Aug 2016 10:53:26 -0700 > Fedora received a report[1] of a unit test failing on Ruby when using > the > 4.7 kernel. This was a test to send a zero sized UDP packet. With the > 4.7 kernel, the test now timing out on a select instead of

Re: [REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread David Miller
From: Laura Abbott Date: Tue, 23 Aug 2016 10:53:26 -0700 > Fedora received a report[1] of a unit test failing on Ruby when using > the > 4.7 kernel. This was a test to send a zero sized UDP packet. With the > 4.7 kernel, the test now timing out on a select instead of completing. > The reduced

[REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Laura Abbott
Hi, Fedora received a report[1] of a unit test failing on Ruby when using the 4.7 kernel. This was a test to send a zero sized UDP packet. With the 4.7 kernel, the test now timing out on a select instead of completing. The reduced ruby test is def test_udp_recvfrom_nonblock u1 =

[REGRESSION] Select hang with zero sized UDP packets

2016-08-23 Thread Laura Abbott
Hi, Fedora received a report[1] of a unit test failing on Ruby when using the 4.7 kernel. This was a test to send a zero sized UDP packet. With the 4.7 kernel, the test now timing out on a select instead of completing. The reduced ruby test is def test_udp_recvfrom_nonblock u1 =