Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

infradead.org, > regressi...@leemhuis.info, Artem Bityutskiy <dedeki...@gmail.com>, > Adrian Hunter <adrian.hun...@intel.com>, David Oberhollenzer > <goli...@sigma-star.at> Betreff: Re: [REGRESSION 4.11] Commit > d8514d8edb5b ("ovl: copy up regular file using O_T

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

rd Weinberger > Cc: Amir Goldstein , Miklos Szeredi > , linux-unio...@vger.kernel.org, linux-kernel > , linux-...@lists.infradead.org, > regressi...@leemhuis.info, Artem Bityutskiy , > Adrian Hunter , David Oberhollenzer > Betreff: Re: [REGRESSION 4.11] Commit > d8514d8ed

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Ralph, Am 30.03.2017 um 07:53 schrieb Ralph Sennhauser: > With this patch I'm no longer able to reproduce _this_ issue, however, > rename no longer works either: > > # mv /etc/config/wireless /etc/config/wireless.back > mv: can't rename '/etc/config/wireless': Invalid argument > # ls

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Ralph, Am 30.03.2017 um 07:53 schrieb Ralph Sennhauser: > With this patch I'm no longer able to reproduce _this_ issue, however, > rename no longer works either: > > # mv /etc/config/wireless /etc/config/wireless.back > mv: can't rename '/etc/config/wireless': Invalid argument > # ls

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Thu, Mar 30, 2017 at 8:53 AM, Ralph Sennhauser wrote: > Hi Richard, > > On Thu, 30 Mar 2017 00:15:31 +0200 > Richard Weinberger wrote: > >> Ralph, >> >> Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: >> >> # create and link a tmpfile - then remove

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Thu, Mar 30, 2017 at 8:53 AM, Ralph Sennhauser wrote: > Hi Richard, > > On Thu, 30 Mar 2017 00:15:31 +0200 > Richard Weinberger wrote: > >> Ralph, >> >> Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: >> >> # create and link a tmpfile - then remove it >> >> sudo rm -rf foo; sudo xfs_io -T -c

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Hi Richard, On Thu, 30 Mar 2017 00:15:31 +0200 Richard Weinberger wrote: > Ralph, > > Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: > >> # create and link a tmpfile - then remove it > >> sudo rm -rf foo; sudo xfs_io -T -c "flink foo" . ; ls -l foo; sudo > >> rm foo > > >

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Hi Richard, On Thu, 30 Mar 2017 00:15:31 +0200 Richard Weinberger wrote: > Ralph, > > Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: > >> # create and link a tmpfile - then remove it > >> sudo rm -rf foo; sudo xfs_io -T -c "flink foo" . ; ls -l foo; sudo > >> rm foo > > > > next-20170328,

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Ralph, Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: >> # create and link a tmpfile - then remove it >> sudo rm -rf foo; sudo xfs_io -T -c "flink foo" . ; ls -l foo; sudo rm >> foo > > next-20170328, obviously without your patch: > > # xfs_io -T -c "flink foo" . > .: Not supported -T

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Ralph, Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: >> # create and link a tmpfile - then remove it >> sudo rm -rf foo; sudo xfs_io -T -c "flink foo" . ; ls -l foo; sudo rm >> foo > > next-20170328, obviously without your patch: > > # xfs_io -T -c "flink foo" . > .: Not supported -T

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Wed, 29 Mar 2017 22:16:10 +0300 Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 3:16 PM, Ralph Sennhauser > wrote: > > On Tue, 28 Mar 2017 08:08:51 -0400 > > Amir Goldstein wrote: > > > >> On Tue, Mar 28, 2017 at 7:28 AM,

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Wed, 29 Mar 2017 22:16:10 +0300 Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 3:16 PM, Ralph Sennhauser > wrote: > > On Tue, 28 Mar 2017 08:08:51 -0400 > > Amir Goldstein wrote: > > > >> On Tue, Mar 28, 2017 at 7:28 AM, Ralph Sennhauser > >> wrote: > >> > Hi Amir, > >> > > >> > On

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Amir, Am 28.03.2017 um 12:43 schrieb Amir Goldstein: > On Tue, Mar 28, 2017 at 5:27 AM, Amir Goldstein wrote: >> On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser >> wrote: >>> Hi Amir >>> >>> Commit d8514d8edb5b ("ovl: copy up regular file using

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Amir, Am 28.03.2017 um 12:43 schrieb Amir Goldstein: > On Tue, Mar 28, 2017 at 5:27 AM, Amir Goldstein wrote: >> On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser >> wrote: >>> Hi Amir >>> >>> Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") >>> breaks squashfs with an ubifs

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 3:16 PM, Ralph Sennhauser wrote: > On Tue, 28 Mar 2017 08:08:51 -0400 > Amir Goldstein wrote: > >> On Tue, Mar 28, 2017 at 7:28 AM, Ralph Sennhauser >> wrote: >> > Hi Amir, >> > >> > On Tue, 28

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 3:16 PM, Ralph Sennhauser wrote: > On Tue, 28 Mar 2017 08:08:51 -0400 > Amir Goldstein wrote: > >> On Tue, Mar 28, 2017 at 7:28 AM, Ralph Sennhauser >> wrote: >> > Hi Amir, >> > >> > On Tue, 28 Mar 2017 07:03:11 -0400 >> > Amir Goldstein wrote: >> > >> >> Overlayfs now

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, 28 Mar 2017 08:08:51 -0400 Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 7:28 AM, Ralph Sennhauser > wrote: > > Hi Amir, > > > > On Tue, 28 Mar 2017 07:03:11 -0400 > > Amir Goldstein wrote: > > > >> Overlayfs now

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, 28 Mar 2017 08:08:51 -0400 Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 7:28 AM, Ralph Sennhauser > wrote: > > Hi Amir, > > > > On Tue, 28 Mar 2017 07:03:11 -0400 > > Amir Goldstein wrote: > > > >> Overlayfs now uses O_TMPFILE for copy up and it works fine with all > >> the file

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 7:28 AM, Ralph Sennhauser wrote: > Hi Amir, > > On Tue, 28 Mar 2017 07:03:11 -0400 > Amir Goldstein wrote: > >> Overlayfs now uses O_TMPFILE for copy up and it works fine with all >> the file systems I tested (tmpfs, xfs,

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 7:28 AM, Ralph Sennhauser wrote: > Hi Amir, > > On Tue, 28 Mar 2017 07:03:11 -0400 > Amir Goldstein wrote: > >> Overlayfs now uses O_TMPFILE for copy up and it works fine with all >> the file systems I tested (tmpfs, xfs, ext4). >> If I am right and O_TMPFILE is broken in

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Hi Amir, On Tue, 28 Mar 2017 07:03:11 -0400 Amir Goldstein wrote: > Overlayfs now uses O_TMPFILE for copy up and it works fine with all > the file systems I tested (tmpfs, xfs, ext4). > If I am right and O_TMPFILE is broken in ubifs, you are most likely > the first person to

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Hi Amir, On Tue, 28 Mar 2017 07:03:11 -0400 Amir Goldstein wrote: > Overlayfs now uses O_TMPFILE for copy up and it works fine with all > the file systems I tested (tmpfs, xfs, ext4). > If I am right and O_TMPFILE is broken in ubifs, you are most likely > the first person to test it (indirectly

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 6:45 AM, Ralph Sennhauser wrote: > On Tue, 28 Mar 2017 05:27:03 -0400 > Amir Goldstein wrote: > >> On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser >> wrote: >> > Hi Amir >> > >> > Commit

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 6:45 AM, Ralph Sennhauser wrote: > On Tue, 28 Mar 2017 05:27:03 -0400 > Amir Goldstein wrote: > >> On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser >> wrote: >> > Hi Amir >> > >> > Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") >> > breaks squashfs

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, 28 Mar 2017 05:27:03 -0400 Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser > wrote: > > Hi Amir > > > > Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") > > breaks squashfs with an ubifs overlay

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, 28 Mar 2017 05:27:03 -0400 Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser > wrote: > > Hi Amir > > > > Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") > > breaks squashfs with an ubifs overlay (both ubi volumes of the same > > container). > >

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 5:27 AM, Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser > wrote: >> Hi Amir >> >> Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") >> breaks squashfs with an ubifs overlay (both

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 5:27 AM, Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser > wrote: >> Hi Amir >> >> Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") >> breaks squashfs with an ubifs overlay (both ubi volumes of the same >> container). >> > > Hi

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser wrote: > Hi Amir > > Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") > breaks squashfs with an ubifs overlay (both ubi volumes of the same > container). > Hi Ralph, I am confused by the description

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

On Tue, Mar 28, 2017 at 4:01 AM, Ralph Sennhauser wrote: > Hi Amir > > Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") > breaks squashfs with an ubifs overlay (both ubi volumes of the same > container). > Hi Ralph, I am confused by the description above. Which are the 'both

[REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Hi Amir Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks squashfs with an ubifs overlay (both ubi volumes of the same container). Renaming a file results in an error "UBIFS error (ubi0:1 pid 1394): ubifs_add_orphan: orphaned twice". This corrupts the the filesystem and

[REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

Hi Amir Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks squashfs with an ubifs overlay (both ubi volumes of the same container). Renaming a file results in an error "UBIFS error (ubi0:1 pid 1394): ubifs_add_orphan: orphaned twice". This corrupts the the filesystem and