Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 03:02:56PM -0600, Doug Maxey wrote: > [added cc: to mikec] > > On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote: > > On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > > > > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > > > Is

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Doug Maxey
[added cc: to mikec] On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote: > On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > > Is the current include from open-iscsi being duplicated? If not, why > > > >

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > Is the current include from open-iscsi being duplicated? If not, why > > > not consolidate in one file? > > > > The include files that come from open-iscsi that are

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Doug Maxey
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > Is the current include from open-iscsi being duplicated? If not, why > > not consolidate in one file? > > The include files that come from open-iscsi that are in the kernel do > not have the iBFT data structures in them - therefore

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: > Overall, looks nice. Good work. Thank you. > > comments inline below... > .. snip .. > > +#include > > Is the current include from open-iscsi being duplicated? If not, why > not consolidate in one file? The include files that

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: Overall, looks nice. Good work. Thank you. comments inline below... .. snip .. +#include linux/iscsi_ibft.h Is the current include from open-iscsi being duplicated? If not, why not consolidate in one file? The include

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Doug Maxey
[added cc: to mikec] On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote: On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: Is the current include from open-iscsi being duplicated? If not, why not

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Doug Maxey
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: Is the current include from open-iscsi being duplicated? If not, why not consolidate in one file? The include files that come from open-iscsi that are in the kernel do not have the iBFT data structures in them - therefore no

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: Is the current include from open-iscsi being duplicated? If not, why not consolidate in one file? The include files that come from open-iscsi that are in the

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 03:02:56PM -0600, Doug Maxey wrote: [added cc: to mikec] On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote: On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: Is the current

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-04 Thread Doug Maxey
Overall, looks nice. Good work. comments inline below... On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote: > On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: > > > > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > > directories along with text

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-04 Thread darnok
On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: > > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > directories along with text properties which export the the iSCSI Boot > Firmware Table (iBFT) structure. > > What is iSCSI Boot Firmware Table? It is a

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-04 Thread darnok
On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-04 Thread Doug Maxey
Overall, looks nice. Good work. comments inline below... On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote: On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text

[REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-11-28 Thread Konrad Rzeszutek
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI

[REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-11-28 Thread Konrad Rzeszutek
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI