Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 01:01pm, Steven Rostedt wrote: > On Wed, 16 Sep 2015 00:32:02 +0800 > Minfei Huang wrote: > > > There is one more confusion. Is it valuable to export such info to > > userspace? What does user do, if kernel exports this? > > Nothing. The dyn_ftrace_total_info is purely for

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Wed, 16 Sep 2015 00:32:02 +0800 Minfei Huang wrote: > There is one more confusion. Is it valuable to export such info to > userspace? What does user do, if kernel exports this? Nothing. The dyn_ftrace_total_info is purely for debugging ftrace. It's something I use. -- Steve -- To

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 12:12pm, Steven Rostedt wrote: > On Wed, 16 Sep 2015 00:00:46 +0800 > Minfei Huang wrote: > > > On 09/15/15 at 11:50am, Steven Rostedt wrote: > > > On Tue, 15 Sep 2015 23:37:39 +0800 > > > Minfei Huang wrote: > > > > > > > > > > I think the variant ftrace_update_time is not

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Wed, 16 Sep 2015 00:00:46 +0800 Minfei Huang wrote: > On 09/15/15 at 11:50am, Steven Rostedt wrote: > > On Tue, 15 Sep 2015 23:37:39 +0800 > > Minfei Huang wrote: > > > > > > > I think the variant ftrace_update_time is not used any more. Previously, > > > it is used to print the time how

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 11:50am, Steven Rostedt wrote: > On Tue, 15 Sep 2015 23:37:39 +0800 > Minfei Huang wrote: > > > > I think the variant ftrace_update_time is not used any more. Previously, > > it is used to print the time how long ftrace will spend to update the > > code in fucntion ftraced. >

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Tue, 15 Sep 2015 23:37:39 +0800 Minfei Huang wrote: > I think the variant ftrace_update_time is not used any more. Previously, > it is used to print the time how long ftrace will spend to update the > code in fucntion ftraced. Yes, I know what it measures. It's been on my todo list to

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 09:35am, Steven Rostedt wrote: > On Tue, 15 Sep 2015 15:10:43 +0800 > Minfei Huang wrote: > > > From: Minfei Huang > > > > Since the patch "ftrace: remove daemon(cb7be3b)" remove the function > > ftraced, the variant ftrace_update_time never be used any more. > > > > Remove the

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Tue, 15 Sep 2015 15:10:43 +0800 Minfei Huang wrote: > From: Minfei Huang > > Since the patch "ftrace: remove daemon(cb7be3b)" remove the function > ftraced, the variant ftrace_update_time never be used any more. > > Remove the unused variant ftrace_update_time. Actually, the patch I would

[REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

From: Minfei Huang Since the patch "ftrace: remove daemon(cb7be3b)" remove the function ftraced, the variant ftrace_update_time never be used any more. Remove the unused variant ftrace_update_time. Signed-off-by: Minfei Huang --- kernel/trace/ftrace.c | 6 -- 1 file changed, 6

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 01:01pm, Steven Rostedt wrote: > On Wed, 16 Sep 2015 00:32:02 +0800 > Minfei Huang wrote: > > > There is one more confusion. Is it valuable to export such info to > > userspace? What does user do, if kernel exports this? > > Nothing. The dyn_ftrace_total_info

[REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

From: Minfei Huang Since the patch "ftrace: remove daemon(cb7be3b)" remove the function ftraced, the variant ftrace_update_time never be used any more. Remove the unused variant ftrace_update_time. Signed-off-by: Minfei Huang --- kernel/trace/ftrace.c

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 11:50am, Steven Rostedt wrote: > On Tue, 15 Sep 2015 23:37:39 +0800 > Minfei Huang wrote: > > > > I think the variant ftrace_update_time is not used any more. Previously, > > it is used to print the time how long ftrace will spend to update the > > code in

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Wed, 16 Sep 2015 00:00:46 +0800 Minfei Huang wrote: > On 09/15/15 at 11:50am, Steven Rostedt wrote: > > On Tue, 15 Sep 2015 23:37:39 +0800 > > Minfei Huang wrote: > > > > > > > I think the variant ftrace_update_time is not used any more. Previously,

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 12:12pm, Steven Rostedt wrote: > On Wed, 16 Sep 2015 00:00:46 +0800 > Minfei Huang wrote: > > > On 09/15/15 at 11:50am, Steven Rostedt wrote: > > > On Tue, 15 Sep 2015 23:37:39 +0800 > > > Minfei Huang wrote: > > > > > > > > > > I think

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Wed, 16 Sep 2015 00:32:02 +0800 Minfei Huang wrote: > There is one more confusion. Is it valuable to export such info to > userspace? What does user do, if kernel exports this? Nothing. The dyn_ftrace_total_info is purely for debugging ftrace. It's something I use. --

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On 09/15/15 at 09:35am, Steven Rostedt wrote: > On Tue, 15 Sep 2015 15:10:43 +0800 > Minfei Huang wrote: > > > From: Minfei Huang > > > > Since the patch "ftrace: remove daemon(cb7be3b)" remove the function > > ftraced, the variant ftrace_update_time

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Tue, 15 Sep 2015 23:37:39 +0800 Minfei Huang wrote: > I think the variant ftrace_update_time is not used any more. Previously, > it is used to print the time how long ftrace will spend to update the > code in fucntion ftraced. Yes, I know what it measures. It's been on

Re: [REPOST PATCH] ftrace: Remove the unused variant ftrace_update_time

On Tue, 15 Sep 2015 15:10:43 +0800 Minfei Huang wrote: > From: Minfei Huang > > Since the patch "ftrace: remove daemon(cb7be3b)" remove the function > ftraced, the variant ftrace_update_time never be used any more. > > Remove the unused variant