Re: [RESEND,v5,1/2] bio: limit bio max size

2021-04-12 Thread Christoph Hellwig
And more importantly please test with a file system that uses the iomap direct I/O code (btrfs, gfs2, ext4, xfs, zonefs) as we should never just work aroudn a legacy codebase that should go away in the block layer.

Re: [RESEND,v5,1/2] bio: limit bio max size

2021-04-12 Thread Changheun Lee
> On Sun, Apr 11, 2021 at 10:13:01PM +, Damien Le Moal wrote: > > On 2021/04/09 23:47, Bart Van Assche wrote: > > > On 4/7/21 3:27 AM, Damien Le Moal wrote: > > >> On 2021/04/07 18:46, Changheun Lee wrote: > > >>> I'll prepare new patch as you recommand. It will be added setting of > > >>>

Re: [RESEND,v5,1/2] bio: limit bio max size

2021-04-11 Thread Ming Lei
On Sun, Apr 11, 2021 at 10:13:01PM +, Damien Le Moal wrote: > On 2021/04/09 23:47, Bart Van Assche wrote: > > On 4/7/21 3:27 AM, Damien Le Moal wrote: > >> On 2021/04/07 18:46, Changheun Lee wrote: > >>> I'll prepare new patch as you recommand. It will be added setting of > >>> limit_bio_size

Re: [RESEND,v5,1/2] bio: limit bio max size

2021-04-11 Thread Damien Le Moal
On 2021/04/09 23:47, Bart Van Assche wrote: > On 4/7/21 3:27 AM, Damien Le Moal wrote: >> On 2021/04/07 18:46, Changheun Lee wrote: >>> I'll prepare new patch as you recommand. It will be added setting of >>> limit_bio_size automatically when queue max sectors is determined. >> >> Please do that

Re: [RESEND,v5,1/2] bio: limit bio max size

2021-04-09 Thread Bart Van Assche
On 4/7/21 3:27 AM, Damien Le Moal wrote: On 2021/04/07 18:46, Changheun Lee wrote: I'll prepare new patch as you recommand. It will be added setting of limit_bio_size automatically when queue max sectors is determined. Please do that in the driver for the HW that benefits from it. Do not do

Re: [RESEND,v5,1/2] bio: limit bio max size

2021-04-07 Thread Damien Le Moal
On 2021/04/07 18:46, Changheun Lee wrote: >> On Wed, Apr 07, 2021 at 03:55:07PM +0900, Changheun Lee wrote: On Wed, Apr 07, 2021 at 02:06:33PM +0900, Changheun Lee wrote: >> On Wed, Apr 07, 2021 at 09:16:12AM +0900, Changheun Lee wrote: On Tue, Apr 06, 2021 at 10:31:28AM +0900,

Re: [RESEND,v5,1/2] bio: limit bio max size

2021-04-07 Thread Changheun Lee
> On Wed, Apr 07, 2021 at 03:55:07PM +0900, Changheun Lee wrote: > > > On Wed, Apr 07, 2021 at 02:06:33PM +0900, Changheun Lee wrote: > > > > > On Wed, Apr 07, 2021 at 09:16:12AM +0900, Changheun Lee wrote: > > > > > > > On Tue, Apr 06, 2021 at 10:31:28AM +0900, Changheun Lee wrote: > > > > > > >