Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-05 Thread Alexandre Belloni
Hi, On 05/01/2016 at 16:31:38 +0800, Huang, Tao wrote : > You and Alexandre are right. The rename is just make the driver more > readable, i.e. let people know this driver suit for more PMIC no just > rk808. In fact, I don't care the name is rk808 or rk8xx. > For this purpose, you can add the

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-05 Thread Huang, Tao
Hi, Alessandro: On 2016年01月04日 21:59, Alessandro Zummo wrote: > On Mon, 4 Jan 2016 10:45:46 +0100 > Alexandre Belloni wrote: > >> I'm not sure it is useful to do that renaming. It is usual to have one >> driver that supports multiple chips named with the forst chip it >> supported. >> >> Also,

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-05 Thread Huang, Tao
Hi, Alessandro: On 2016年01月04日 21:59, Alessandro Zummo wrote: > On Mon, 4 Jan 2016 10:45:46 +0100 > Alexandre Belloni wrote: > >> I'm not sure it is useful to do that renaming. It is usual to have one >> driver that supports multiple chips named with the

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-05 Thread Alexandre Belloni
Hi, On 05/01/2016 at 16:31:38 +0800, Huang, Tao wrote : > You and Alexandre are right. The rename is just make the driver more > readable, i.e. let people know this driver suit for more PMIC no just > rk808. In fact, I don't care the name is rk808 or rk8xx. > For this purpose, you can add the

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Alessandro Zummo
On Mon, 4 Jan 2016 10:45:46 +0100 Alexandre Belloni wrote: > I'm not sure it is useful to do that renaming. It is usual to have one > driver that supports multiple chips named with the forst chip it > supported. > > Also, what would happen if for example rk855 is not compatible at all > with

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Alexandre Belloni
Hi, On 31/12/2015 at 06:14:55 -0800, zhangqing wrote : > make rtc-rk8xx.c compatible for all pmic chips. > for pmic chips(rk808\rk807\rk816\rk818) in the future. > I'm not sure it is useful to do that renaming. It is usual to have one driver that supports multiple chips named with the forst

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Kever Yang
Hi Zhang Qing, On 12/31/2015 10:14 PM, zhangqing wrote: make rtc-rk8xx.c compatible for all pmic chips. for pmic chips(rk808\rk807\rk816\rk818) in the future. The commit message will be better like this: Rename the file to rtc-rk8xx.c to compatible other Rockchip PMIC chips like

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Kever Yang
Hi Zhang Qing, On 12/31/2015 10:14 PM, zhangqing wrote: make rtc-rk8xx.c compatible for all pmic chips. for pmic chips(rk808\rk807\rk816\rk818) in the future. The commit message will be better like this: Rename the file to rtc-rk8xx.c to compatible other Rockchip PMIC chips like

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Alexandre Belloni
Hi, On 31/12/2015 at 06:14:55 -0800, zhangqing wrote : > make rtc-rk8xx.c compatible for all pmic chips. > for pmic chips(rk808\rk807\rk816\rk818) in the future. > I'm not sure it is useful to do that renaming. It is usual to have one driver that supports multiple chips named with the forst

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Alessandro Zummo
On Mon, 4 Jan 2016 10:45:46 +0100 Alexandre Belloni wrote: > I'm not sure it is useful to do that renaming. It is usual to have one > driver that supports multiple chips named with the forst chip it > supported. > > Also, what would happen if for example

[RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2015-12-30 Thread zhangqing
make rtc-rk8xx.c compatible for all pmic chips. for pmic chips(rk808\rk807\rk816\rk818) in the future. Signed-off-by: zhangqing --- drivers/mfd/rk808.c | 2 +- drivers/rtc/Kconfig | 8 +- drivers/rtc/Makefile | 2 +-

[RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2015-12-30 Thread zhangqing
make rtc-rk8xx.c compatible for all pmic chips. for pmic chips(rk808\rk807\rk816\rk818) in the future. Signed-off-by: zhangqing --- drivers/mfd/rk808.c | 2 +- drivers/rtc/Kconfig | 8 +- drivers/rtc/Makefile