RE: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-04 Thread Hatayama, Daisuke
..@aristanetworks.com' > > Subject: Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip > > Hello, > > On Fri, Jun 01, 2018 at 09:25:32AM +, Hatayama, Daisuke wrote: > > kernfs_dir_pos() checks if a kernfs_node object given as one of its > > argumen

RE: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-04 Thread Hatayama, Daisuke
..@aristanetworks.com' > > Subject: Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip > > Hello, > > On Fri, Jun 01, 2018 at 09:25:32AM +, Hatayama, Daisuke wrote: > > kernfs_dir_pos() checks if a kernfs_node object given as one of its > > argumen

Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-02 Thread Eric W. Biederman
"Hatayama, Daisuke" writes: > kernfs_dir_next_pos() overlooks the situation that the dentry > corresponding to a given pos object has already been inactive. Hence, > when kernfs_dir_pos() returns the dentry with a hash value larger than > the original one, kernfs_dir_next_pos() returns the

Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-02 Thread Eric W. Biederman
"Hatayama, Daisuke" writes: > kernfs_dir_next_pos() overlooks the situation that the dentry > corresponding to a given pos object has already been inactive. Hence, > when kernfs_dir_pos() returns the dentry with a hash value larger than > the original one, kernfs_dir_next_pos() returns the

Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-01 Thread 't...@kernel.org'
Hello, On Fri, Jun 01, 2018 at 09:25:32AM +, Hatayama, Daisuke wrote: > kernfs_dir_pos() checks if a kernfs_node object given as one of its > arguments is still active and if so returns it, or returns a > kernfs_node object that is most equal (possibly smaller and larger) to > the given

Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-01 Thread 't...@kernel.org'
Hello, On Fri, Jun 01, 2018 at 09:25:32AM +, Hatayama, Daisuke wrote: > kernfs_dir_pos() checks if a kernfs_node object given as one of its > arguments is still active and if so returns it, or returns a > kernfs_node object that is most equal (possibly smaller and larger) to > the given

RE: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-01 Thread Hatayama, Daisuke
..@aristanetworks.com' > > Subject: Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip > > Hello, > > On Mon, May 28, 2018 at 12:54:03PM +, Hatayama, Daisuke wrote: > > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c > > index 89d1dc1..3aeeb7a 100644 > > --- a

RE: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-06-01 Thread Hatayama, Daisuke
..@aristanetworks.com' > > Subject: Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip > > Hello, > > On Mon, May 28, 2018 at 12:54:03PM +, Hatayama, Daisuke wrote: > > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c > > index 89d1dc1..3aeeb7a 100644 > > --- a

Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-05-29 Thread 't...@kernel.org'
Hello, On Mon, May 28, 2018 at 12:54:03PM +, Hatayama, Daisuke wrote: > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c > index 89d1dc1..3aeeb7a 100644 > --- a/fs/kernfs/dir.c > +++ b/fs/kernfs/dir.c > @@ -1621,8 +1621,10 @@ static int kernfs_dir_fop_release(struct inode *inode, > struct file

Re: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-05-29 Thread 't...@kernel.org'
Hello, On Mon, May 28, 2018 at 12:54:03PM +, Hatayama, Daisuke wrote: > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c > index 89d1dc1..3aeeb7a 100644 > --- a/fs/kernfs/dir.c > +++ b/fs/kernfs/dir.c > @@ -1621,8 +1621,10 @@ static int kernfs_dir_fop_release(struct inode *inode, > struct file

RE: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-05-28 Thread Hatayama, Daisuke
M > To: 'gre...@linuxfoundation.org' <gre...@linuxfoundation.org>; > 't...@kernel.org' <t...@kernel.org> > Cc: Okajima, Toshiyuki <toshi.okaj...@jp.fujitsu.com>; > linux-kernel@vger.kernel.org; 'ebied...@aristanetworks.com' > <ebied...@aristanetworks.com> > Su

RE: [RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-05-28 Thread Hatayama, Daisuke
M > To: 'gre...@linuxfoundation.org' ; > 't...@kernel.org' > Cc: Okajima, Toshiyuki ; > linux-kernel@vger.kernel.org; 'ebied...@aristanetworks.com' > > Subject: [RESEND PATCH v2] kernfs: fix dentry unexpected skip > > kernfs_dir_next_pos() overlooks the situation that the d

[RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-05-28 Thread Hatayama, Daisuke
kernfs_dir_next_pos() overlooks the situation that the dentry corresponding to a given pos object has already been inactive. Hence, when kernfs_dir_pos() returns the dentry with a hash value larger than the original one, kernfs_dir_next_pos() returns the dentry next to the one returned by

[RESEND PATCH v2] kernfs: fix dentry unexpected skip

2018-05-28 Thread Hatayama, Daisuke
kernfs_dir_next_pos() overlooks the situation that the dentry corresponding to a given pos object has already been inactive. Hence, when kernfs_dir_pos() returns the dentry with a hash value larger than the original one, kernfs_dir_next_pos() returns the dentry next to the one returned by