Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Muchun Song
On Tue, Dec 8, 2020 at 4:33 AM Hugh Dickins wrote: > > On Mon, 7 Dec 2020, Roman Gushchin wrote: > > On Mon, Dec 07, 2020 at 04:02:54PM +0100, Michal Hocko wrote: > > > > > > As I've said the THP accounting change makes more sense to me because it > > > allows future changes which are already

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Muchun Song
On Mon, Dec 7, 2020 at 11:02 PM Michal Hocko wrote: > > On Mon 07-12-20 22:52:30, Muchun Song wrote: > > On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: > > > > > > On Sun 06-12-20 18:14:39, Muchun Song wrote: > > > > Hi, > > > > > > > > This patch series is aimed to convert all THP vmstat

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Muchun Song
On Tue, Dec 8, 2020 at 2:51 AM Randy Dunlap wrote: > > On 12/7/20 7:02 AM, Michal Hocko wrote: > > On Mon 07-12-20 22:52:30, Muchun Song wrote: > >> On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: > >>> > >>> On Sun 06-12-20 18:14:39, Muchun Song wrote: > Hi, > > This patch

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Hugh Dickins
On Mon, 7 Dec 2020, Roman Gushchin wrote: > On Mon, Dec 07, 2020 at 04:02:54PM +0100, Michal Hocko wrote: > > > > As I've said the THP accounting change makes more sense to me because it > > allows future changes which are already undergoing so there is more > > merit in those. > > +1 > And this

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Roman Gushchin
On Mon, Dec 07, 2020 at 04:02:54PM +0100, Michal Hocko wrote: > On Mon 07-12-20 22:52:30, Muchun Song wrote: > > On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: > > > > > > On Sun 06-12-20 18:14:39, Muchun Song wrote: > > > > Hi, > > > > > > > > This patch series is aimed to convert all THP

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Randy Dunlap
On 12/7/20 7:02 AM, Michal Hocko wrote: > On Mon 07-12-20 22:52:30, Muchun Song wrote: >> On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: >>> >>> On Sun 06-12-20 18:14:39, Muchun Song wrote: Hi, This patch series is aimed to convert all THP vmstat counters to pages and some

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Michal Hocko
On Mon 07-12-20 22:52:30, Muchun Song wrote: > On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: > > > > On Sun 06-12-20 18:14:39, Muchun Song wrote: > > > Hi, > > > > > > This patch series is aimed to convert all THP vmstat counters to pages > > > and some KiB vmstat counters to bytes. > > > >

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Muchun Song
On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: > > On Sun 06-12-20 18:14:39, Muchun Song wrote: > > Hi, > > > > This patch series is aimed to convert all THP vmstat counters to pages > > and some KiB vmstat counters to bytes. > > > > The unit of some vmstat counters are pages, some are bytes,

Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Michal Hocko
On Sun 06-12-20 18:14:39, Muchun Song wrote: > Hi, > > This patch series is aimed to convert all THP vmstat counters to pages > and some KiB vmstat counters to bytes. > > The unit of some vmstat counters are pages, some are bytes, some are > HPAGE_PMD_NR, and some are KiB. When we want to expose

[RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-06 Thread Muchun Song
Hi, This patch series is aimed to convert all THP vmstat counters to pages and some KiB vmstat counters to bytes. The unit of some vmstat counters are pages, some are bytes, some are HPAGE_PMD_NR, and some are KiB. When we want to expose these vmstat counters to the userspace, we have to know