Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 06:25:16PM +0800, Jisheng Zhang wrote: > On Wed, 27 Apr 2016 10:57:39 +0100 Mark Brown wrote: > > On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: > > > > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > > > devm_regulator_get_optional() ?? > > Do

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Felipe Balbi
Hi, Mark Brown writes: > On Wed, Apr 27, 2016 at 01:25:27PM +0300, Felipe Balbi wrote: >> Mark Brown writes: > >> > this to be just a normal regulator_get(). > >> jokes aside, this regulator is optional because not all platforms >> require a SW controlled regulator, no ? Will normal regulator_g

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 01:25:27PM +0300, Felipe Balbi wrote: > Mark Brown writes: > > this to be just a normal regulator_get(). > jokes aside, this regulator is optional because not all platforms > require a SW controlled regulator, no ? Will normal regulator_get() give > us a dummy regulator i

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Jisheng Zhang
Dear Mark, On Wed, 27 Apr 2016 10:57:39 +0100 Mark Brown wrote: > On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: > > Jisheng Zhang writes: > > > > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > > > devm_regulator_get_optional() ?? > > Does USB work without a VBUS? Un

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Felipe Balbi
Hi, Mark Brown writes: > On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: >> Jisheng Zhang writes: > >> > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > >> devm_regulator_get_optional() ?? > > Does USB work without a VBUS? Unless the answer is yes then I'd expect it can, ju

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: > Jisheng Zhang writes: > > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > devm_regulator_get_optional() ?? Does USB work without a VBUS? Unless the answer is yes then I'd expect this to be just a normal regulator_get(). > >

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-26 Thread Felipe Balbi
Hi, Jisheng Zhang writes: > The Marvell BG4CT STB board has board level vbus control through gpio. > This patch adds the vbus regulator control to support this board. > > Signed-off-by: Jisheng Zhang > --- > drivers/usb/host/xhci-plat.c | 40 +++- > drivers/

[RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-26 Thread Jisheng Zhang
The Marvell BG4CT STB board has board level vbus control through gpio. This patch adds the vbus regulator control to support this board. Signed-off-by: Jisheng Zhang --- drivers/usb/host/xhci-plat.c | 40 +++- drivers/usb/host/xhci.h | 2 ++ 2 files chan