Re: [RESEND PATCH v2 8/8] Input: sx8654 - convert #defined flags to BIT(x)

2019-02-04 Thread Dmitry Torokhov
On Tue, Jan 29, 2019 at 12:23:01PM +0100, Richard Leitner wrote: > Hi Joe, > > On 29/01/2019 06:40, Joe Perches wrote: > > On Mon, 2019-01-28 at 16:25 -0800, Dmitry Torokhov wrote: > > > On Tue, Dec 18, 2018 at 09:40:02AM +0100, Richard Leitner wrote: > > > > Some of the #defined register values

Re: [RESEND PATCH v2 8/8] Input: sx8654 - convert #defined flags to BIT(x)

2019-01-29 Thread Richard Leitner
Hi Joe, On 29/01/2019 06:40, Joe Perches wrote: On Mon, 2019-01-28 at 16:25 -0800, Dmitry Torokhov wrote: On Tue, Dec 18, 2018 at 09:40:02AM +0100, Richard Leitner wrote: Some of the #defined register values are one-bit flags. Convert them to use the BIT(x) macro instead of 1 byte hexadecimal

Re: [RESEND PATCH v2 8/8] Input: sx8654 - convert #defined flags to BIT(x)

2019-01-28 Thread Joe Perches
On Mon, 2019-01-28 at 16:25 -0800, Dmitry Torokhov wrote: > On Tue, Dec 18, 2018 at 09:40:02AM +0100, Richard Leitner wrote: > > Some of the #defined register values are one-bit flags. Convert them to > > use the BIT(x) macro instead of 1 byte hexadecimal values. This improves > > readability and

Re: [RESEND PATCH v2 8/8] Input: sx8654 - convert #defined flags to BIT(x)

2019-01-28 Thread Dmitry Torokhov
On Tue, Dec 18, 2018 at 09:40:02AM +0100, Richard Leitner wrote: > Some of the #defined register values are one-bit flags. Convert them to > use the BIT(x) macro instead of 1 byte hexadecimal values. This improves > readability and clarifies the intent. > > Signed-off-by: Richard Leitner

[RESEND PATCH v2 8/8] Input: sx8654 - convert #defined flags to BIT(x)

2018-12-18 Thread Richard Leitner
Some of the #defined register values are one-bit flags. Convert them to use the BIT(x) macro instead of 1 byte hexadecimal values. This improves readability and clarifies the intent. Signed-off-by: Richard Leitner --- drivers/input/touchscreen/sx8654.c | 11 ++- 1 file changed, 6