Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-09 Thread Brian Norris
On Tue, Mar 08, 2016 at 05:25:13PM +0800, Jiancheng Xue wrote: > On 2016/3/8 6:52, Brian Norris wrote: > [...] > >> +static void hisi_spi_nor_dma_transfer(struct spi_nor *nor, u32 start_off, > >> + u32 dma_buf, u32 len, u8 op_type) > > > > Does this controller support 64-bit addresses?

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-09 Thread Brian Norris
On Tue, Mar 08, 2016 at 05:25:13PM +0800, Jiancheng Xue wrote: > On 2016/3/8 6:52, Brian Norris wrote: > [...] > >> +static void hisi_spi_nor_dma_transfer(struct spi_nor *nor, u32 start_off, > >> + u32 dma_buf, u32 len, u8 op_type) > > > > Does this controller support 64-bit addresses?

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-08 Thread Jiancheng Xue
Hi Boris, On 2016/3/8 17:46, Boris Brezillon wrote: >> [...] +static int hisi_spi_nor_read_reg(struct spi_nor *nor, u8 opcode, u8 *buf, + int len) +{ + struct hifmc_priv *priv = nor->priv; + struct hifmc_host *host = priv->host; + int ret; + +

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-08 Thread Jiancheng Xue
Hi Boris, On 2016/3/8 17:46, Boris Brezillon wrote: >> [...] +static int hisi_spi_nor_read_reg(struct spi_nor *nor, u8 opcode, u8 *buf, + int len) +{ + struct hifmc_priv *priv = nor->priv; + struct hifmc_host *host = priv->host; + int ret; + +

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-08 Thread Boris Brezillon
On Tue, 8 Mar 2016 17:25:13 +0800 Jiancheng Xue wrote: > Hi Brian, >Thank you very much for your comments. > > On 2016/3/8 6:52, Brian Norris wrote: > [...] > >> > >> diff --git a/Documentation/devicetree/bindings/spi/spi-hisi-sfc.txt > >>

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-08 Thread Boris Brezillon
On Tue, 8 Mar 2016 17:25:13 +0800 Jiancheng Xue wrote: > Hi Brian, >Thank you very much for your comments. > > On 2016/3/8 6:52, Brian Norris wrote: > [...] > >> > >> diff --git a/Documentation/devicetree/bindings/spi/spi-hisi-sfc.txt > >>

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-08 Thread Jiancheng Xue
Hi Brian, Thank you very much for your comments. On 2016/3/8 6:52, Brian Norris wrote: [...] >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-hisi-sfc.txt >> b/Documentation/devicetree/bindings/spi/spi-hisi-sfc.txt >> new file mode 100644 >> index 000..7407147 >> --- /dev/null

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-08 Thread Jiancheng Xue
Hi Brian, Thank you very much for your comments. On 2016/3/8 6:52, Brian Norris wrote: [...] >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-hisi-sfc.txt >> b/Documentation/devicetree/bindings/spi/spi-hisi-sfc.txt >> new file mode 100644 >> index 000..7407147 >> --- /dev/null

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-07 Thread Brian Norris
On Fri, Feb 26, 2016 at 04:11:56PM +0800, Jiancheng Xue wrote: > Add hisilicon spi-nor flash controller driver > > Signed-off-by: Binquan Peng > Signed-off-by: Jiancheng Xue > Acked-by: Rob Herring > Reviewed-by: Ezequiel Garcia

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-07 Thread Brian Norris
On Fri, Feb 26, 2016 at 04:11:56PM +0800, Jiancheng Xue wrote: > Add hisilicon spi-nor flash controller driver > > Signed-off-by: Binquan Peng > Signed-off-by: Jiancheng Xue > Acked-by: Rob Herring > Reviewed-by: Ezequiel Garcia > --- > change log > v7: > Rebased to v4.5-rc3. > Fixed issues

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-04 Thread Ezequiel Garcia
Hi Jiancheng, On 26 February 2016 at 05:11, Jiancheng Xue wrote: [..] > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > index 0dc9275..c86d7cf 100644 > --- a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -37,6 +37,12 @@

Re: [RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-03-04 Thread Ezequiel Garcia
Hi Jiancheng, On 26 February 2016 at 05:11, Jiancheng Xue wrote: [..] > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > index 0dc9275..c86d7cf 100644 > --- a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -37,6 +37,12 @@ config SPI_FSL_QUADSPI >

[RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-02-26 Thread Jiancheng Xue
Add hisilicon spi-nor flash controller driver Signed-off-by: Binquan Peng Signed-off-by: Jiancheng Xue Acked-by: Rob Herring Reviewed-by: Ezequiel Garcia --- change log v7: Rebased to v4.5-rc3.

[RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-02-26 Thread Jiancheng Xue
Add hisilicon spi-nor flash controller driver Signed-off-by: Binquan Peng Signed-off-by: Jiancheng Xue Acked-by: Rob Herring Reviewed-by: Ezequiel Garcia --- change log v7: Rebased to v4.5-rc3. Fixed issues pointed by Ezequiel Garcia. v6: Based on v4.5-rc2 Fixed issues pointed by Ezequiel