Re: [RESEND PATCHv4 1/1] drivers/amba: add reset control to amba bus probe

2019-08-26 Thread Dinh Nguyen
Hi Philipp, On 8/26/19 3:57 AM, Philipp Zabel wrote: > Hi Dinh, Linus, > > On Fri, 2019-08-23 at 10:42 -0500, Dinh Nguyen wrote: >> >> On 8/23/19 4:19 AM, Linus Walleij wrote: >>> On Tue, Aug 20, 2019 at 4:58 PM Dinh Nguyen wrote: >>> @@ -401,6 +402,26 @@ static int

Re: [RESEND PATCHv4 1/1] drivers/amba: add reset control to amba bus probe

2019-08-26 Thread Philipp Zabel
Hi Dinh, Linus, On Fri, 2019-08-23 at 10:42 -0500, Dinh Nguyen wrote: > > On 8/23/19 4:19 AM, Linus Walleij wrote: > > On Tue, Aug 20, 2019 at 4:58 PM Dinh Nguyen wrote: > > > > > @@ -401,6 +402,26 @@ static int amba_device_try_add(struct amba_device > > > *dev, struct resource *parent) > > >

Re: [RESEND PATCHv4 1/1] drivers/amba: add reset control to amba bus probe

2019-08-23 Thread Dinh Nguyen
On 8/23/19 4:19 AM, Linus Walleij wrote: > On Tue, Aug 20, 2019 at 4:58 PM Dinh Nguyen wrote: > >> @@ -401,6 +402,26 @@ static int amba_device_try_add(struct amba_device *dev, >> struct resource *parent) >> ret = amba_get_enable_pclk(dev); >> if (ret == 0) { >>

Re: [RESEND PATCHv4 1/1] drivers/amba: add reset control to amba bus probe

2019-08-23 Thread Linus Walleij
On Tue, Aug 20, 2019 at 4:58 PM Dinh Nguyen wrote: > @@ -401,6 +402,26 @@ static int amba_device_try_add(struct amba_device *dev, > struct resource *parent) > ret = amba_get_enable_pclk(dev); > if (ret == 0) { > u32 pid, cid; > + int count; > +

[RESEND PATCHv4 1/1] drivers/amba: add reset control to amba bus probe

2019-08-20 Thread Dinh Nguyen
The primecell controller on some SoCs, i.e. SoCFPGA, is held in reset by default. Until recently, the DMA controller was brought out of reset by the bootloader(i.e. U-Boot). But a recent change in U-Boot, the peripherals that are not used are held in reset and are left to Linux to bring them out