Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-05 Thread Gyungoh Yoo
On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: > On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: > > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > > From: Gyungoh Yoo > > > > > > Signed-off-by: Gyungoh Yoo > > > > This doesn't apply against current

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-05 Thread Gyungoh Yoo
On Tue, Nov 04, 2014 at 11:41:20AM +, Mark Brown wrote: > On Tue, Nov 04, 2014 at 02:45:34PM +0900, Gyungoh Yoo wrote: > > On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > > > > I'm having a hard time understanding why it is difficult to split the > > > two changes - they are in

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-05 Thread Gyungoh Yoo
On Tue, Nov 04, 2014 at 11:41:20AM +, Mark Brown wrote: On Tue, Nov 04, 2014 at 02:45:34PM +0900, Gyungoh Yoo wrote: On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: I'm having a hard time understanding why it is difficult to split the two changes - they are in completely

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-05 Thread Gyungoh Yoo
On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com This

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-04 Thread Mark Brown
On Tue, Nov 04, 2014 at 02:45:34PM +0900, Gyungoh Yoo wrote: > On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > > I'm having a hard time understanding why it is difficult to split the > > two changes - they are in completely separate files. > I am sorry for the hard time. > That

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-04 Thread Mark Brown
On Tue, Nov 04, 2014 at 02:45:34PM +0900, Gyungoh Yoo wrote: On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: I'm having a hard time understanding why it is difficult to split the two changes - they are in completely separate files. I am sorry for the hard time. That was

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Gyungoh Yoo
On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: > > On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > > > > This doesn't apply against current code and depends on the MFD symbol > > > rename - can you please

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Mark Brown
On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: > On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: > > it doesn't seem obviously related to the driver > > change and should probably be in the same patch as the MFD symbol rename > > for bisetion. > I don't think there will be

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Mark Brown
On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: > On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > > This doesn't apply against current code and depends on the MFD symbol > > rename - can you please check what's going on here? > Are you talking about

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Gyungoh Yoo
On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > This doesn't apply against current code and depends on the MFD symbol > rename - can you please check

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Paul Bolle
On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > This doesn't apply against current code and depends on the MFD symbol > rename - can you please check what's

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Paul Bolle
On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com This doesn't apply against current code and depends on the MFD symbol

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Gyungoh Yoo
On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com This doesn't apply against current code and depends on the MFD

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Mark Brown
On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: This doesn't apply against current code and depends on the MFD symbol rename - can you please check what's going on here? Are you talking about 'sky81452-regulator'? I

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Mark Brown
On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: it doesn't seem obviously related to the driver change and should probably be in the same patch as the MFD symbol rename for bisetion. I don't think there will be bisection

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Gyungoh Yoo
On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: This doesn't apply against current code and depends on the MFD symbol rename - can you please check what's

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-31 Thread Mark Brown
On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo This doesn't apply against current code and depends on the MFD symbol rename - can you please check what's going on here? It would make sense to split the Kconfig symbol

[RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-31 Thread gyungoh
From: Gyungoh Yoo Signed-off-by: Gyungoh Yoo --- Changes v6: Added new line character at the end of line of dev_err() Changes v5: Changed DT for regulator : 'lout' node should be defined under 'regulator' Removed compatible string Modified to return EINVAL when of_node is NULL Changes v4:

[RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-31 Thread gyungoh
From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com --- Changes v6: Added new line character at the end of line of dev_err() Changes v5: Changed DT for regulator : 'lout' node should be defined under 'regulator' Removed compatible string Modified to

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-31 Thread Mark Brown
On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com This doesn't apply against current code and depends on the MFD symbol rename - can you please check what's going on here? It would