Re: [REVIEW][PATCH 13/11] ipc/smack: Tidy up from the change in type of the ipc security hooks

2018-03-28 Thread Davidlohr Bueso
On Sat, 24 Mar 2018, Eric W. Biederman wrote: /** - * smack_of_shm - the smack pointer for the shm - * @shp: the object + * smack_of_ipc - the smack pointer for the ipc + * @isp: the object Nit, but while at it the @isp description does need some love: "@isp: the pointer for the ipc perm stru

Re: [REVIEW][PATCH 13/11] ipc/smack: Tidy up from the change in type of the ipc security hooks

2018-03-28 Thread Davidlohr Bueso
On Sat, 24 Mar 2018, Casey Schaufler wrote: On 3/23/2018 10:42 PM, Eric W. Biederman wrote: Rename the variables shp, sma, msq to isp. As that is how the code already refers to those variables. Thanks. It's important to keep the code readable. Ah great, ignore my last email then.

Re: [REVIEW][PATCH 13/11] ipc/smack: Tidy up from the change in type of the ipc security hooks

2018-03-24 Thread Casey Schaufler
On 3/23/2018 10:42 PM, Eric W. Biederman wrote: > Rename the variables shp, sma, msq to isp. As that is how the code already > refers to those variables. Thanks. It's important to keep the code readable. > Collapse smack_of_shm, smack_of_sem, and smack_of_msq into smack_of_ipc, > as the three fun

[REVIEW][PATCH 13/11] ipc/smack: Tidy up from the change in type of the ipc security hooks

2018-03-23 Thread Eric W. Biederman
Rename the variables shp, sma, msq to isp. As that is how the code already refers to those variables. Collapse smack_of_shm, smack_of_sem, and smack_of_msq into smack_of_ipc, as the three functions had become completely identical. Collapse smack_shm_alloc_security, smack_sem_alloc_security and s