Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 15:46:32 +0100 Pablo Neira Ayuso wrote: > > > > > > Acked-by: Pablo Neira Ayuso > > > > > > to this patch and 4/8. > > > > Thanks for this! > > > > Can I get someone to ack 3/8? > > I don't see any 3/8 in my inbox, only 2/8 and 4/8. > > Let me know, thanks. I replied

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 04 Nov 2014 06:46:19 -0800 Joe Perches wrote: > On Tue, 2014-11-04 at 09:31 -0500, Steven Rostedt wrote: > > On Tue, 4 Nov 2014 15:22:36 +0100 > > Pablo Neira Ayuso wrote: > > > On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: > > > > On Wed, 29 Oct 2014 17:56:04 -0400

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 15:46:32 +0100 Pablo Neira Ayuso wrote: > > Can I get someone to ack 3/8? > > I don't see any 3/8 in my inbox, only 2/8 and 4/8. > > Let me know, thanks. Strange, you were on the Cc of that patch. Let me go back and check to make sure that didn't bounce too. -- Steve --

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Joe Perches
On Tue, 2014-11-04 at 09:31 -0500, Steven Rostedt wrote: > On Tue, 4 Nov 2014 15:22:36 +0100 > Pablo Neira Ayuso wrote: > > On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: > > > On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt > > > wrote: > > > > From: "Steven Rostedt (Red

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Pablo Neira Ayuso
On Tue, Nov 04, 2014 at 09:31:50AM -0500, Steven Rostedt wrote: > On Tue, 4 Nov 2014 15:22:36 +0100 > Pablo Neira Ayuso wrote: > > > On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: > > > On Wed, 29 Oct 2014 17:56:04 -0400 > > > Steven Rostedt wrote: > > > > > > > From: "Steven

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 15:22:36 +0100 Pablo Neira Ayuso wrote: > On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: > > On Wed, 29 Oct 2014 17:56:04 -0400 > > Steven Rostedt wrote: > > > > > From: "Steven Rostedt (Red Hat)" > > > > > > [ REQUEST FOR ACKS ] > > > > Can any of the

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Pablo Neira Ayuso
On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: > On Wed, 29 Oct 2014 17:56:04 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (Red Hat)" > > > > [ REQUEST FOR ACKS ] > > Can any of the netfilter folks give me an Acked-by for this? If Florian's concern were

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 08:05:35 -0500 Steven Rostedt wrote: > On Wed, 29 Oct 2014 17:56:04 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (Red Hat)" > > > > [ REQUEST FOR ACKS ] > > Can any of the netfilter folks give me an Acked-by for this? > I hope nobody expects Jozsef

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > [ REQUEST FOR ACKS ] Can any of the netfilter folks give me an Acked-by for this? Thanks! -- Steve > > The seq_printf() and friends are having their return values removed. > The

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org [ REQUEST FOR ACKS ] Can any of the netfilter folks give me an Acked-by for this? Thanks! -- Steve The seq_printf() and friends are having their return values

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 08:05:35 -0500 Steven Rostedt rost...@goodmis.org wrote: On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org [ REQUEST FOR ACKS ] Can any of the netfilter folks give me an Acked-by for

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Pablo Neira Ayuso
On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org [ REQUEST FOR ACKS ] Can any of the netfilter folks give me an Acked-by for this? If

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 15:22:36 +0100 Pablo Neira Ayuso pa...@netfilter.org wrote: On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org [

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Pablo Neira Ayuso
On Tue, Nov 04, 2014 at 09:31:50AM -0500, Steven Rostedt wrote: On Tue, 4 Nov 2014 15:22:36 +0100 Pablo Neira Ayuso pa...@netfilter.org wrote: On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt rost...@goodmis.org wrote:

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Joe Perches
On Tue, 2014-11-04 at 09:31 -0500, Steven Rostedt wrote: On Tue, 4 Nov 2014 15:22:36 +0100 Pablo Neira Ayuso pa...@netfilter.org wrote: On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: On Wed, 29 Oct 2014 17:56:04 -0400 Steven Rostedt rost...@goodmis.org wrote: From:

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 15:46:32 +0100 Pablo Neira Ayuso pa...@netfilter.org wrote: Can I get someone to ack 3/8? I don't see any 3/8 in my inbox, only 2/8 and 4/8. Let me know, thanks. Strange, you were on the Cc of that patch. Let me go back and check to make sure that didn't bounce too.

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 04 Nov 2014 06:46:19 -0800 Joe Perches j...@perches.com wrote: On Tue, 2014-11-04 at 09:31 -0500, Steven Rostedt wrote: On Tue, 4 Nov 2014 15:22:36 +0100 Pablo Neira Ayuso pa...@netfilter.org wrote: On Tue, Nov 04, 2014 at 08:05:35AM -0500, Steven Rostedt wrote: On Wed, 29 Oct

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-11-04 Thread Steven Rostedt
On Tue, 4 Nov 2014 15:46:32 +0100 Pablo Neira Ayuso pa...@netfilter.org wrote: Acked-by: Pablo Neira Ayuso pa...@netfilter.org to this patch and 4/8. Thanks for this! Can I get someone to ack 3/8? I don't see any 3/8 in my inbox, only 2/8 and 4/8. Let me know,

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Steven Rostedt
On Wed, 29 Oct 2014 23:16:01 +0100 Florian Westphal wrote: > Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > [ REQUEST FOR ACKS ] > > > > The seq_printf() and friends are having their return values removed. > > The print_conntrack() returns the result of seq_printf(),

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Steven Rostedt
On Wed, 29 Oct 2014 23:16:01 +0100 Florian Westphal wrote: > Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > [ REQUEST FOR ACKS ] > > > > The seq_printf() and friends are having their return values removed. > > The print_conntrack() returns the result of seq_printf(),

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Florian Westphal
Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > [ REQUEST FOR ACKS ] > > The seq_printf() and friends are having their return values removed. > The print_conntrack() returns the result of seq_printf(), which is > meaningless when seq_printf() returns void. Might as well remove the

[RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" [ REQUEST FOR ACKS ] The seq_printf() and friends are having their return values removed. The print_conntrack() returns the result of seq_printf(), which is meaningless when seq_printf() returns void. Might as well remove the return values of print_conntrack()

[RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Steven Rostedt
From: Steven Rostedt (Red Hat) rost...@goodmis.org [ REQUEST FOR ACKS ] The seq_printf() and friends are having their return values removed. The print_conntrack() returns the result of seq_printf(), which is meaningless when seq_printf() returns void. Might as well remove the return values of

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Florian Westphal
Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org [ REQUEST FOR ACKS ] The seq_printf() and friends are having their return values removed. The print_conntrack() returns the result of seq_printf(), which is meaningless when seq_printf() returns

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Steven Rostedt
On Wed, 29 Oct 2014 23:16:01 +0100 Florian Westphal f...@strlen.de wrote: Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org [ REQUEST FOR ACKS ] The seq_printf() and friends are having their return values removed. The print_conntrack()

Re: [RFA][PATCH 2/8] netfilter: Remove return values for print_conntrack callbacks

2014-10-29 Thread Steven Rostedt
On Wed, 29 Oct 2014 23:16:01 +0100 Florian Westphal f...@strlen.de wrote: Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org [ REQUEST FOR ACKS ] The seq_printf() and friends are having their return values removed. The print_conntrack()