Re: [RFC,3/5] squashfs: remove cache for normal data page

2013-10-06 Thread Minchan Kim
On Fri, Oct 04, 2013 at 07:13:31AM +0100, Phillip Lougher wrote: > Minchan Kim wrote: > >Sqsuashfs have used cache for normal data pages but it's pointless > >because MM already has cache layer and squashfs adds extra pages > >into MM's page cache when it reads a page from compressed block. > > >

re: [RFC,3/5] squashfs: remove cache for normal data page

2013-10-03 Thread Phillip Lougher
Minchan Kim wrote: Sqsuashfs have used cache for normal data pages but it's pointless because MM already has cache layer and squashfs adds extra pages into MM's page cache when it reads a page from compressed block. This patch removes cache usage for normal data pages so it could remove unneces

Re: squashfs enhance [RFC 3/5] squashfs: remove cache for normal data page

2013-09-25 Thread Minchan Kim
Hello Phillip, On Thu, Sep 26, 2013 at 04:18:39AM +0100, Phillip Lougher wrote: > > Minchan Kim wrote: > > > >Hello chintu, > > > > > >On Wed, Sep 25, 2013 at 5:13 PM, chintu kumar wrote: > >>Hi Minchan, > >> > >>Thanks for the response! > >> > >>I checked add_to_page_cache_lru and you are righ

Re: squashfs enhance [RFC 3/5] squashfs: remove cache for normal data page

2013-09-25 Thread Phillip Lougher
Minchan Kim wrote: Hello chintu, On Wed, Sep 25, 2013 at 5:13 PM, chintu kumar wrote: Hi Minchan, Thanks for the response! I checked add_to_page_cache_lru and you are right for existing pages in page cache it won't add the page you allocated so my questions are answered thank you. Howeve

Re: squashfs enhance [RFC 3/5] squashfs: remove cache for normal data page

2013-09-25 Thread Minchan Kim
Hello chintu, On Wed, Sep 25, 2013 at 5:13 PM, chintu kumar wrote: > Hi Minchan, > > Thanks for the response! > > I checked add_to_page_cache_lru and you are right for existing pages in page > cache it won't add the page you allocated so my questions are answered thank > you. However my concern i

[RFC 3/5] squashfs: remove cache for normal data page

2013-09-16 Thread Minchan Kim
Sqsuashfs have used cache for normal data pages but it's pointless because MM already has cache layer and squashfs adds extra pages into MM's page cache when it reads a page from compressed block. This patch removes cache usage for normal data pages so it could remove unnecessary one copy(ie, from