Re: [RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
One more thing... On 4/21/05, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Thu, 2005-04-21 at 02:07 -0500, Dmitry Torokhov wrote: > > > w1-master-drop-attrs.patch > >Get rid of unneeded master device attributes: > >- 'pointer' and 'attempts' are meaningless for userspace; > >-

Re: [RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
Hi Evgeniy, On 4/21/05, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Thu, 2005-04-21 at 02:07 -0500, Dmitry Torokhov wrote: > > Hi, > > Hello, Dmitry. > > > I happened to take a look into drivers/w1 and found there bunch of thigs > > that IMO should be changed: > > > > - custom-made

Re: [RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Evgeniy Polyakov
On Thu, 2005-04-21 at 02:07 -0500, Dmitry Torokhov wrote: > Hi, Hello, Dmitry. > I happened to take a look into drivers/w1 and found there bunch of thigs > that IMO should be changed: > > - custom-made refcounting is racy Why do you think so? Did you find exactly the place which races against

[RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
Hi, I happened to take a look into drivers/w1 and found there bunch of thigs that IMO should be changed: - custom-made refcounting is racy - lifetime rules need to be better enforced - family framework is insufficient for many advanced w1 devices - custom-made hotplug notification over netlink

[RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
Hi, I happened to take a look into drivers/w1 and found there bunch of thigs that IMO should be changed: - custom-made refcounting is racy - lifetime rules need to be better enforced - family framework is insufficient for many advanced w1 devices - custom-made hotplug notification over netlink

Re: [RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Evgeniy Polyakov
On Thu, 2005-04-21 at 02:07 -0500, Dmitry Torokhov wrote: Hi, Hello, Dmitry. I happened to take a look into drivers/w1 and found there bunch of thigs that IMO should be changed: - custom-made refcounting is racy Why do you think so? Did you find exactly the place which races against

Re: [RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
Hi Evgeniy, On 4/21/05, Evgeniy Polyakov [EMAIL PROTECTED] wrote: On Thu, 2005-04-21 at 02:07 -0500, Dmitry Torokhov wrote: Hi, Hello, Dmitry. I happened to take a look into drivers/w1 and found there bunch of thigs that IMO should be changed: - custom-made refcounting is racy

Re: [RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
One more thing... On 4/21/05, Evgeniy Polyakov [EMAIL PROTECTED] wrote: On Thu, 2005-04-21 at 02:07 -0500, Dmitry Torokhov wrote: w1-master-drop-attrs.patch Get rid of unneeded master device attributes: - 'pointer' and 'attempts' are meaningless for userspace; - information