Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-23 Thread Grant Grundler
Just a style nit... On Tue, Dec 18, 2007 at 10:01:14AM +1100, Benjamin Herrenschmidt wrote: > This patch converts users of pci_enable_device_bars() to the new > pci_enable_device_{io,mem} interface. > > The new API fits nicely, except maybe for the QLA case where a bit of > code re-organization m

Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-17 Thread Benjamin Herrenschmidt
On Tue, 2007-12-18 at 00:07 +, Alan Cox wrote: > On Tue, 18 Dec 2007 10:01:14 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > This patch converts users of pci_enable_device_bars() to the new > > pci_enable_device_{io,mem} interface. > > > > The new API fits nicely, except may

Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-17 Thread Alan Cox
On Tue, 18 Dec 2007 10:01:14 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > This patch converts users of pci_enable_device_bars() to the new > pci_enable_device_{io,mem} interface. > > The new API fits nicely, except maybe for the QLA case where a bit of > code re-organization might be

[RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-17 Thread Benjamin Herrenschmidt
This patch converts users of pci_enable_device_bars() to the new pci_enable_device_{io,mem} interface. The new API fits nicely, except maybe for the QLA case where a bit of code re-organization might be a good idea but I prefer sticking to the simple patch as I don't have hardware to test on. I'l