Re: [RFC/PATCH RESEND -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory

2014-07-15 Thread Andrey Ryabinin
On 07/15/14 18:26, Christoph Lameter wrote: > On Tue, 15 Jul 2014, Joonsoo Kim wrote: > >>> I think putting disable/enable only where we strictly need them might be a >>> problem for future maintenance of slub. >>> If someone is going to add a new function call somewhere, he must ensure >>> that

Re: [RFC/PATCH RESEND -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory

2014-07-15 Thread Christoph Lameter
On Tue, 15 Jul 2014, Joonsoo Kim wrote: > > I think putting disable/enable only where we strictly need them might be a > > problem for future maintenance of slub. > > If someone is going to add a new function call somewhere, he must ensure > > that it this call won't be a problem > > for kasan.

Re: [RFC/PATCH RESEND -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory

2014-07-15 Thread Andrey Ryabinin
On 07/15/14 12:18, Joonsoo Kim wrote: > On Tue, Jul 15, 2014 at 11:37:56AM +0400, Andrey Ryabinin wrote: >> On 07/15/14 10:04, Joonsoo Kim wrote: >>> On Wed, Jul 09, 2014 at 03:30:08PM +0400, Andrey Ryabinin wrote: Some code in slub could validly touch memory marked by kasan as unaccessi

Re: [RFC/PATCH RESEND -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory

2014-07-15 Thread Joonsoo Kim
On Tue, Jul 15, 2014 at 11:37:56AM +0400, Andrey Ryabinin wrote: > On 07/15/14 10:04, Joonsoo Kim wrote: > > On Wed, Jul 09, 2014 at 03:30:08PM +0400, Andrey Ryabinin wrote: > >> Some code in slub could validly touch memory marked by kasan as > >> unaccessible. > >> Even though slub.c doesn't inst

Re: [RFC/PATCH RESEND -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory

2014-07-15 Thread Andrey Ryabinin
On 07/15/14 10:04, Joonsoo Kim wrote: > On Wed, Jul 09, 2014 at 03:30:08PM +0400, Andrey Ryabinin wrote: >> Some code in slub could validly touch memory marked by kasan as unaccessible. >> Even though slub.c doesn't instrumented, functions called in it are >> instrumented, >> so to avoid false pos

Re: [RFC/PATCH RESEND -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory

2014-07-14 Thread Joonsoo Kim
On Wed, Jul 09, 2014 at 03:30:08PM +0400, Andrey Ryabinin wrote: > Some code in slub could validly touch memory marked by kasan as unaccessible. > Even though slub.c doesn't instrumented, functions called in it are > instrumented, > so to avoid false positive reports such places are protected by >

[RFC/PATCH RESEND -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory

2014-07-09 Thread Andrey Ryabinin
Some code in slub could validly touch memory marked by kasan as unaccessible. Even though slub.c doesn't instrumented, functions called in it are instrumented, so to avoid false positive reports such places are protected by kasan_disable_local()/kasan_enable_local() calls. Signed-off-by: Andrey R