Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 09:22 +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 09:49:04PM -0700, Srinivas Pandruvada wrote: > > Setup necessary infrastructure to be able to boost HWP performance > > on a > > remote CPU. First initialize data structure to be able to use > > smp_call_function_sin

Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 12:43 +0200, Peter Zijlstra wrote: > On Wed, May 16, 2018 at 11:15:09AM +0200, Rafael J. Wysocki wrote: > > > So if the "cached" thing is the last "not boosted EPP", that's why > > it > > is not updated here. > > Sure, I see what it does, just saying that naming and comments

Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits

2018-05-16 Thread Peter Zijlstra
On Wed, May 16, 2018 at 11:15:09AM +0200, Rafael J. Wysocki wrote: > So if the "cached" thing is the last "not boosted EPP", that's why it > is not updated here. Sure, I see what it does, just saying that naming and comments are wrong vs the actual code.

Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits

2018-05-16 Thread Rafael J. Wysocki
On Wed, May 16, 2018 at 9:22 AM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 09:49:04PM -0700, Srinivas Pandruvada wrote: >> Setup necessary infrastructure to be able to boost HWP performance on a >> remote CPU. First initialize data structure to be able to use >> smp_call_function_single_asyn

Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits

2018-05-16 Thread Peter Zijlstra
On Tue, May 15, 2018 at 09:49:04PM -0700, Srinivas Pandruvada wrote: > Setup necessary infrastructure to be able to boost HWP performance on a > remote CPU. First initialize data structure to be able to use > smp_call_function_single_async(). The boost up function simply set HWP > min to HWP max va

[RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits

2018-05-15 Thread Srinivas Pandruvada
Setup necessary infrastructure to be able to boost HWP performance on a remote CPU. First initialize data structure to be able to use smp_call_function_single_async(). The boost up function simply set HWP min to HWP max value and EPP to 0. The boost down function simply restores to last cached HWP