Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-17 Thread Peter Zijlstra
On Wed, May 16, 2018 at 03:40:39PM -0700, Srinivas Pandruvada wrote: > On Wed, 2018-05-16 at 10:11 +0200, Peter Zijlstra wrote: > > So I _really_ hate this... I'd much rather you make schedutil work > > with the hwp passive stuff. > Are you not happy with ifdefs are utility function itself? Can

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-17 Thread Peter Zijlstra
On Wed, May 16, 2018 at 03:40:39PM -0700, Srinivas Pandruvada wrote: > On Wed, 2018-05-16 at 10:11 +0200, Peter Zijlstra wrote: > > So I _really_ hate this... I'd much rather you make schedutil work > > with the hwp passive stuff. > Are you not happy with ifdefs are utility function itself? Can

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 10:11 +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 09:49:07PM -0700, Srinivas Pandruvada wrote: > > --- a/kernel/sched/cpufreq.c > > +++ b/kernel/sched/cpufreq.c > > @@ -60,3 +60,26 @@ void cpufreq_remove_update_util_hook(int cpu) > >

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 10:11 +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 09:49:07PM -0700, Srinivas Pandruvada wrote: > > --- a/kernel/sched/cpufreq.c > > +++ b/kernel/sched/cpufreq.c > > @@ -60,3 +60,26 @@ void cpufreq_remove_update_util_hook(int cpu) > >

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 12:10 +0530, Viresh Kumar wrote: > On 15-05-18, 21:49, Srinivas Pandruvada wrote: > > Added cpufreq_get_sched_util() to get the CFS, DL and max > > utilization > > values for a CPU. This is required for getting utilization values > > for cpufreq drivers outside of

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 12:10 +0530, Viresh Kumar wrote: > On 15-05-18, 21:49, Srinivas Pandruvada wrote: > > Added cpufreq_get_sched_util() to get the CFS, DL and max > > utilization > > values for a CPU. This is required for getting utilization values > > for cpufreq drivers outside of

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Peter Zijlstra
On Tue, May 15, 2018 at 09:49:07PM -0700, Srinivas Pandruvada wrote: > --- a/kernel/sched/cpufreq.c > +++ b/kernel/sched/cpufreq.c > @@ -60,3 +60,26 @@ void cpufreq_remove_update_util_hook(int cpu) > rcu_assign_pointer(per_cpu(cpufreq_update_util_data, cpu), NULL); > } >

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Peter Zijlstra
On Tue, May 15, 2018 at 09:49:07PM -0700, Srinivas Pandruvada wrote: > --- a/kernel/sched/cpufreq.c > +++ b/kernel/sched/cpufreq.c > @@ -60,3 +60,26 @@ void cpufreq_remove_update_util_hook(int cpu) > rcu_assign_pointer(per_cpu(cpufreq_update_util_data, cpu), NULL); > } >

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Viresh Kumar
On 15-05-18, 21:49, Srinivas Pandruvada wrote: > Added cpufreq_get_sched_util() to get the CFS, DL and max utilization > values for a CPU. This is required for getting utilization values > for cpufreq drivers outside of kernel/sched folder. > > Signed-off-by: Srinivas Pandruvada

Re: [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-16 Thread Viresh Kumar
On 15-05-18, 21:49, Srinivas Pandruvada wrote: > Added cpufreq_get_sched_util() to get the CFS, DL and max utilization > values for a CPU. This is required for getting utilization values > for cpufreq drivers outside of kernel/sched folder. > > Signed-off-by: Srinivas Pandruvada > --- >

[RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-15 Thread Srinivas Pandruvada
Added cpufreq_get_sched_util() to get the CFS, DL and max utilization values for a CPU. This is required for getting utilization values for cpufreq drivers outside of kernel/sched folder. Signed-off-by: Srinivas Pandruvada --- include/linux/sched/cpufreq.h |

[RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values

2018-05-15 Thread Srinivas Pandruvada
Added cpufreq_get_sched_util() to get the CFS, DL and max utilization values for a CPU. This is required for getting utilization values for cpufreq drivers outside of kernel/sched folder. Signed-off-by: Srinivas Pandruvada --- include/linux/sched/cpufreq.h | 2 ++ kernel/sched/cpufreq.c