Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-08 Thread Stephen Hemminger
On Mon, 8 Oct 2007 17:33:53 +0200 "Vegard Nossum" <[EMAIL PROTECTED]> wrote: > On 10/8/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > On Sun, 7 Oct 2007 16:50:49 -0500 > > Rob Landley <[EMAIL PROTECTED]> wrote: > > > > > On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: > > > > On

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-08 Thread Vegard Nossum
On 10/8/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Sun, 7 Oct 2007 16:50:49 -0500 > Rob Landley <[EMAIL PROTECTED]> wrote: > > > On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: > > > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > I made it about halfway through the

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-08 Thread Stephen Hemminger
On Sun, 7 Oct 2007 16:50:49 -0500 Rob Landley <[EMAIL PROTECTED]> wrote: > On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: > > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > > The original idea (selectively compile out printk() instances based on > > > log level to conserve

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-08 Thread Stephen Hemminger
On Sun, 7 Oct 2007 16:50:49 -0500 Rob Landley [EMAIL PROTECTED] wrote: On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: The original idea (selectively compile out printk() instances based on log level to conserve space) is

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-08 Thread Vegard Nossum
On 10/8/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sun, 7 Oct 2007 16:50:49 -0500 Rob Landley [EMAIL PROTECTED] wrote: On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: I made it about halfway through the patch and the

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-08 Thread Stephen Hemminger
On Mon, 8 Oct 2007 17:33:53 +0200 Vegard Nossum [EMAIL PROTECTED] wrote: On 10/8/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sun, 7 Oct 2007 16:50:49 -0500 Rob Landley [EMAIL PROTECTED] wrote: On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: On 10/5/07, Rob Landley

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Randy Dunlap
On Sun, 7 Oct 2007 16:56:01 -0500 Rob Landley wrote: > On Friday 05 October 2007 6:01:10 pm Miguel Ojeda wrote: > > > *shrug* That doesn't mean my objections are important to anyone else, > > > just that I don't personally see any reason to be enthusiastic about this > > > patch. > > > > Take a

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Rob Landley
On Friday 05 October 2007 6:01:10 pm Miguel Ojeda wrote: > > *shrug* That doesn't mean my objections are important to anyone else, > > just that I don't personally see any reason to be enthusiastic about this > > patch. > > Take a look to other suggested changes, maybe you like some of them > and

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Rob Landley
On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > The original idea (selectively compile out printk() instances based on > > log level to conserve space) is explicitly not addressed by this patch, > > and in fact this patch might

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Miguel Ojeda
On 10/6/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Sat, 6 Oct 2007 01:01:10 +0200 > "Miguel Ojeda" <[EMAIL PROTECTED]> wrote: > > > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > > On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: > > > > > > > > I think we all are trying

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Miguel Ojeda
On 10/6/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sat, 6 Oct 2007 01:01:10 +0200 Miguel Ojeda [EMAIL PROTECTED] wrote: On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: I think we all are trying to give ideas to

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Rob Landley
On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: The original idea (selectively compile out printk() instances based on log level to conserve space) is explicitly not addressed by this patch, and in fact this patch might actually

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Rob Landley
On Friday 05 October 2007 6:01:10 pm Miguel Ojeda wrote: *shrug* That doesn't mean my objections are important to anyone else, just that I don't personally see any reason to be enthusiastic about this patch. Take a look to other suggested changes, maybe you like some of them and you will

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Randy Dunlap
On Sun, 7 Oct 2007 16:56:01 -0500 Rob Landley wrote: On Friday 05 October 2007 6:01:10 pm Miguel Ojeda wrote: *shrug* That doesn't mean my objections are important to anyone else, just that I don't personally see any reason to be enthusiastic about this patch. Take a look to other

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-06 Thread Vegard Nossum
On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > The original idea (selectively compile out printk() instances based on log > level to conserve space) is explicitly not addressed by this patch, and in > fact this patch might actually make it harder to implement (by complicating > the code).

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-06 Thread Vegard Nossum
On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: The original idea (selectively compile out printk() instances based on log level to conserve space) is explicitly not addressed by this patch, and in fact this patch might actually make it harder to implement (by complicating the code). This is

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Stephen Hemminger
On Sat, 6 Oct 2007 01:01:10 +0200 "Miguel Ojeda" <[EMAIL PROTECTED]> wrote: > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: > > > > > > I think we all are trying to give ideas to improve the current logging > > > API. > > > > > >

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Miguel Ojeda
On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: > > > > I think we all are trying to give ideas to improve the current logging API. > > > > If something works, it's great; but it doesn't mean that it can't be > > improved, right? > >

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Alan Cox
> > With the current code, localisation is not possible to do in a sane > > way. > > Run dmesg through a filter in userspace using lots of regular expressions. > Your average perl junkie could knock out a basic prototype in 20 minutes. He did say "sane". Good internationalisation requires you

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Rob Landley
On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: > > Last I checked, the current prink() worked just fine. Why is this _not_ > > the dreaded "infrastructure in search of a use"? What exactly can we > > _not_ do with the current code? What does this allow us to remove and > > simplify? >

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Rob Landley
On Friday 05 October 2007 8:13:09 am Vegard Nossum wrote: > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: > > > On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: > > > > Description: This patch largely implements the kprint

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Vegard Nossum
On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: > > On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: > > > Description: This patch largely implements the kprint API as previously > > > posted to the LKML and described in

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Miguel Ojeda
On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: > > On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: > > > Description: This patch largely implements the kprint API as previously > > > posted to the LKML and described in

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Miguel Ojeda
On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: Description: This patch largely implements the kprint API as previously posted to the LKML and described in

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Vegard Nossum
On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: Description: This patch largely implements the kprint API as previously posted to the LKML and described in

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Rob Landley
On Friday 05 October 2007 8:13:09 am Vegard Nossum wrote: On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: Description: This patch largely implements the kprint API as

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Rob Landley
On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: Last I checked, the current prink() worked just fine. Why is this _not_ the dreaded infrastructure in search of a use? What exactly can we _not_ do with the current code? What does this allow us to remove and simplify? I'm

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Alan Cox
With the current code, localisation is not possible to do in a sane way. Run dmesg through a filter in userspace using lots of regular expressions. Your average perl junkie could knock out a basic prototype in 20 minutes. He did say sane. Good internationalisation requires you know

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Miguel Ojeda
On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: I think we all are trying to give ideas to improve the current logging API. If something works, it's great; but it doesn't mean that it can't be improved, right? I'm all for

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Stephen Hemminger
On Sat, 6 Oct 2007 01:01:10 +0200 Miguel Ojeda [EMAIL PROTECTED] wrote: On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: I think we all are trying to give ideas to improve the current logging API. If something works, it's

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-04 Thread Rob Landley
On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: > On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: > > Description: This patch largely implements the kprint API as previously > > posted to the LKML and described in Documentation/kprint.txt (see patch). > > > > The main purpose of

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-04 Thread Randy Dunlap
On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: > Description: This patch largely implements the kprint API as previously > posted to the LKML and described in Documentation/kprint.txt (see patch). > > The main purpose of this change is provide a unified logging API to the > kernel and

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-04 Thread Randy Dunlap
On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: Description: This patch largely implements the kprint API as previously posted to the LKML and described in Documentation/kprint.txt (see patch). The main purpose of this change is provide a unified logging API to the kernel and at the

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-04 Thread Rob Landley
On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: Description: This patch largely implements the kprint API as previously posted to the LKML and described in Documentation/kprint.txt (see patch). The main purpose of this