Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-28 Thread Tom Gundersen
Hi Rusty, On Tue, Jan 28, 2014 at 2:35 AM, Rusty Russell wrote: > Tom Gundersen writes: >> Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where >> the >> second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all >> the modaliases being exposed. > > No Si

Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-27 Thread Rusty Russell
Greg Kroah-Hartman writes: > On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote: >> Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where >> the >> second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all >> the modaliases being exposed. >> >>

Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-27 Thread Rusty Russell
Tom Gundersen writes: > Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the > second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all > the modaliases being exposed. No Signed-off-by? Thanks, Rusty. > > This fixes the problem by including the name

Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-27 Thread Dmitry Torokhov
On Mon, Jan 27, 2014 at 11:54:22AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote: > > Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where > > the > > second call to MODULE_DEVICE_TABLE() overrode the first resulting in not a

Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-27 Thread Greg Kroah-Hartman
On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote: > Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the > second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all > the modaliases being exposed. > > This fixes the problem by including the

[RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-27 Thread Tom Gundersen
Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all the modaliases being exposed. This fixes the problem by including the name of the device_id table in the __mod_*_device_table alias, allowing