Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Francois Romieu
Greg KH <[EMAIL PROTECTED]> : > On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote: > > Adam Belay <[EMAIL PROTECTED]> : > > [...] > > > > Some nits + a suspect error branch. It seems nice otherwise. > > If I'm correct, this patch only moves the code into different files, it >

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Adam Belay
On Thu, 2005-07-14 at 12:30 -0700, Greg KH wrote: > On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote: > > Adam Belay <[EMAIL PROTECTED]> : > > [...] > > > > Some nits + a suspect error branch. It seems nice otherwise. > > If I'm correct, this patch only moves the code into

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Greg KH
On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote: > Adam Belay <[EMAIL PROTECTED]> : > [...] > > Some nits + a suspect error branch. It seems nice otherwise. If I'm correct, this patch only moves the code into different files, it doesn't change any of it, so your comments apply to

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread John Rose
I like it. I'm a little hung up on the fact that actual device probing happens in config.c rather than probe.c (if I'm correct). Regardless, this patch set cleans things up nicely. John - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Francois Romieu
Adam Belay <[EMAIL PROTECTED]> : [...] Some nits + a suspect error branch. It seems nice otherwise. > --- a/drivers/pci/bus/bus.c 1969-12-31 19:00:00.0 -0500 > +++ b/drivers/pci/bus/bus.c 2005-07-10 22:32:53.0 -0400 [...] > +struct pci_bus * pci_alloc_bus(void) > +{ > +

[RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Adam Belay
This patch divides the PCI probing code into three smaller files: config.c - PCI configuration space parsing probe.c - PCI bus detection routines bus.c - the PCI bus class driver core These files are placed in the new directory "drivers/pci/bus". It will be used for functions related to the PCI

[RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Adam Belay
This patch divides the PCI probing code into three smaller files: config.c - PCI configuration space parsing probe.c - PCI bus detection routines bus.c - the PCI bus class driver core These files are placed in the new directory drivers/pci/bus. It will be used for functions related to the PCI

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Francois Romieu
Adam Belay [EMAIL PROTECTED] : [...] Some nits + a suspect error branch. It seems nice otherwise. --- a/drivers/pci/bus/bus.c 1969-12-31 19:00:00.0 -0500 +++ b/drivers/pci/bus/bus.c 2005-07-10 22:32:53.0 -0400 [...] +struct pci_bus * pci_alloc_bus(void) +{ + struct

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Greg KH
On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote: Adam Belay [EMAIL PROTECTED] : [...] Some nits + a suspect error branch. It seems nice otherwise. If I'm correct, this patch only moves the code into different files, it doesn't change any of it, so your comments apply to the

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Adam Belay
On Thu, 2005-07-14 at 12:30 -0700, Greg KH wrote: On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote: Adam Belay [EMAIL PROTECTED] : [...] Some nits + a suspect error branch. It seems nice otherwise. If I'm correct, this patch only moves the code into different files, it

Re: [RFC][PATCH] split PCI probing code [1/9]

2005-07-14 Thread Francois Romieu
Greg KH [EMAIL PROTECTED] : On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote: Adam Belay [EMAIL PROTECTED] : [...] Some nits + a suspect error branch. It seems nice otherwise. If I'm correct, this patch only moves the code into different files, it doesn't change any of