Re: [linux-pm] Re: [RFC][PATCH -mm 3/4] Hibernation: Pass CR3 in the image header on x86_64

2007-08-24 Thread Rafael J. Wysocki
On Friday, 24 August 2007 11:02, Pavel Machek wrote: > Hi! > > > > > No, I do not think I like that. I believe both -> control and -> crc > > > > is just useless paranoia. Bitflip in this area is not going to be any > > > > worse than bitflip anywhere else, we should not pretend this is > > > > so

Re: [linux-pm] Re: [RFC][PATCH -mm 3/4] Hibernation: Pass CR3 in the image header on x86_64

2007-08-24 Thread Pavel Machek
Hi! > > > No, I do not think I like that. I believe both -> control and -> crc > > > is just useless paranoia. Bitflip in this area is not going to be any > > > worse than bitflip anywhere else, we should not pretend this is > > > somehow "more important". > > > > > > -> control should really be

Re: [linux-pm] Re: [RFC][PATCH -mm 3/4] Hibernation: Pass CR3 in the image header on x86_64

2007-08-22 Thread Rafael J. Wysocki
On Wednesday, 22 August 2007 18:17, Rafael J. Wysocki wrote: > On Wednesday, 22 August 2007 10:28, Pavel Machek wrote: > > Hi! > > > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > > > Since we already pass the address of restore_registers() in the image > > > header, > > > we can also p

Re: [RFC][PATCH -mm 3/4] Hibernation: Pass CR3 in the image header on x86_64

2007-08-22 Thread Rafael J. Wysocki
On Wednesday, 22 August 2007 10:28, Pavel Machek wrote: > Hi! > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Since we already pass the address of restore_registers() in the image > > header, > > we can also pass the value of the CR3 register from before the hibernation > > in > > the

Re: [RFC][PATCH -mm 3/4] Hibernation: Pass CR3 in the image header on x86_64

2007-08-22 Thread Pavel Machek
Hi! > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Since we already pass the address of restore_registers() in the image header, > we can also pass the value of the CR3 register from before the hibernation in > the same way. This will allow us to avoid using init_level4_pgt page tables > duri

[RFC][PATCH -mm 3/4] Hibernation: Pass CR3 in the image header on x86_64

2007-08-22 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Since we already pass the address of restore_registers() in the image header, we can also pass the value of the CR3 register from before the hibernation in the same way. This will allow us to avoid using init_level4_pgt page tables during the restore.