Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-21 Thread Satyam Sharma
Hi Keiichi, > Please do consider configfs. Note that we'll have to lose the sysfs > symlink from your target's kobject to the kobject of the ethernet > device if we switch to configfs, but was that symlink needed for > some essential functionality or was it simply for informational > purpose?

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-21 Thread Keiichi KII
Hello Satyam, Hmm, I might've missed this thread, but my opinion on the alternatives, fwiw: 1. I think adding new ioctl's to the kernel are generally disliked for obvious reasons. Perhaps Stephen meant to add some generic ioctl's above (and not separate ones specially implemented for the

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-21 Thread Keiichi KII
Hello Satyam, Hmm, I might've missed this thread, but my opinion on the alternatives, fwiw: 1. I think adding new ioctl's to the kernel are generally disliked for obvious reasons. Perhaps Stephen meant to add some generic ioctl's above (and not separate ones specially implemented for the

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-21 Thread Satyam Sharma
Hi Keiichi, Please do consider configfs. Note that we'll have to lose the sysfs symlink from your target's kobject to the kobject of the ethernet device if we switch to configfs, but was that symlink needed for some essential functionality or was it simply for informational purpose? IMHO,

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-19 Thread Satyam Sharma
Hi again Keiichi, On 6/19/07, Keiichi KII <[EMAIL PROTECTED]> wrote: Hello Satyam, > *ugh*. I was wondering what a show-stopper this particular patch > was -- introduces a couple of ioctl()'s, exports a new structure to > userspace, adds a hitherto-unneeded header file, brings in >

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-19 Thread Keiichi KII
Hello Satyam, *ugh*. I was wondering what a show-stopper this particular patch was -- introduces a couple of ioctl()'s, exports a new structure to userspace, adds a hitherto-unneeded header file, brings in tty_struct/tty_operations and ends up adding so much complexity/ bloat to netconsole.c.

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-19 Thread Keiichi KII
Hello Satyam, *ugh*. I was wondering what a show-stopper this particular patch was -- introduces a couple of ioctl()'s, exports a new structure to userspace, adds a hitherto-unneeded header file, brings in tty_struct/tty_operations and ends up adding so much complexity/ bloat to netconsole.c.

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-19 Thread Satyam Sharma
Hi again Keiichi, On 6/19/07, Keiichi KII [EMAIL PROTECTED] wrote: Hello Satyam, *ugh*. I was wondering what a show-stopper this particular patch was -- introduces a couple of ioctl()'s, exports a new structure to userspace, adds a hitherto-unneeded header file, brings in

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-13 Thread Satyam Sharma
Hi Keiichi, On 6/13/07, Keiichi KII <[EMAIL PROTECTED]> wrote: From: Keiichi KII <[EMAIL PROTECTED]> We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe

[RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netconsole target. We attach a sample program for ioctl.

[RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-13 Thread Keiichi KII
From: Keiichi KII [EMAIL PROTECTED] We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netconsole target. We attach a sample program for ioctl.

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-13 Thread Satyam Sharma
Hi Keiichi, On 6/13/07, Keiichi KII [EMAIL PROTECTED] wrote: From: Keiichi KII [EMAIL PROTECTED] We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe