Quoting Paul Dickson ([EMAIL PROTECTED]):
> On Mon, 14 May 2007 13:23:06 -0700, Badari Pulavarty wrote:
>
> > > + while (fs) {
> > > + locked = union_trylock(fs->root);
> > > + if (!locked)
> > > + goto loop1;
> > > + locked = union_trylock(fs->altroot);
>
Quoting Paul Dickson ([EMAIL PROTECTED]):
On Mon, 14 May 2007 13:23:06 -0700, Badari Pulavarty wrote:
+ while (fs) {
+ locked = union_trylock(fs-root);
+ if (!locked)
+ goto loop1;
+ locked = union_trylock(fs-altroot);
+ if
On May 19 2007 03:18, Paul Dickson wrote:
>
>How about getting rid of the gotos:
>
> while (fs) {
> locked = union_trylock(fs->root);
> if (locked) {
> locked = union_trylock(fs->altroot);
> if (locked) {
>
On May 19 2007 03:18, Paul Dickson wrote:
How about getting rid of the gotos:
while (fs) {
locked = union_trylock(fs-root);
if (locked) {
locked = union_trylock(fs-altroot);
if (locked) {
On Mon, 14 May 2007 13:23:06 -0700, Badari Pulavarty wrote:
> > + while (fs) {
> > + locked = union_trylock(fs->root);
> > + if (!locked)
> > + goto loop1;
> > + locked = union_trylock(fs->altroot);
> > + if (!locked)
> > +
On Mon, 14 May 2007 13:23:06 -0700, Badari Pulavarty wrote:
+ while (fs) {
+ locked = union_trylock(fs-root);
+ if (!locked)
+ goto loop1;
+ locked = union_trylock(fs-altroot);
+ if (!locked)
+ goto loop2;
On 5/14/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
>+static inline void union_lock(struct dentry *dentry)
>+{
>+ if (unlikely(dentry && dentry->d_union)) {
>+ struct union_info *ui = dentry->d_union;
>+
>+ UM_DEBUG_LOCK("\"%s\" locking %p (count=%d)\n",
>+
On Mon, May 14, 2007 at 03:40:57PM -0700, Badari Pulavarty wrote:
> On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote:
< snip >
> > +
> > +/* Shouldn't be called with last reference to union_info */
> > +static inline void union_put_and_unlock(struct union_info *uinfo)
> > +{
> > +
On Mon, May 14, 2007 at 03:40:57PM -0700, Badari Pulavarty wrote:
On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote:
snip
+
+/* Shouldn't be called with last reference to union_info */
+static inline void union_put_and_unlock(struct union_info *uinfo)
+{
+ union_put(uinfo);
+
On 5/14/07, Jan Engelhardt [EMAIL PROTECTED] wrote:
+static inline void union_lock(struct dentry *dentry)
+{
+ if (unlikely(dentry dentry-d_union)) {
+ struct union_info *ui = dentry-d_union;
+
+ UM_DEBUG_LOCK(\%s\ locking %p (count=%d)\n,
+
On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote:
> From: Jan Blunck <[EMAIL PROTECTED]>
> Subject: Introduce union stack.
>
> Adds union stack infrastructure to the dentry structure and provides
> locking routines to walk the union stack.
...
> --- /dev/null
> +++
On May 14 2007 13:23, Badari Pulavarty wrote:
>> +static inline void union_lock_fs(struct fs_struct *fs)
>> +{
>> +int locked;
>> +
>> +while (fs) {
>> +locked = union_trylock(fs->root);
>> +if (!locked)
>> +goto loop1;
>> +locked =
On May 14 2007 15:10, Bharata B Rao wrote:
>+struct union_info * union_alloc(void)
Ultimate nitpick: try s/\* /*/; (also elsewhere)
>+static inline void union_lock(struct dentry *dentry)
>+{
>+ if (unlikely(dentry && dentry->d_union)) {
>+ struct union_info *ui =
On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote:
> From: Jan Blunck <[EMAIL PROTECTED]>
> Subject: Introduce union stack.
>
> Adds union stack infrastructure to the dentry structure and provides
> locking routines to walk the union stack.
>
> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]>
From: Jan Blunck <[EMAIL PROTECTED]>
Subject: Introduce union stack.
Adds union stack infrastructure to the dentry structure and provides
locking routines to walk the union stack.
Signed-off-by: Jan Blunck <[EMAIL PROTECTED]>
Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]>
---
fs/Makefile
From: Jan Blunck [EMAIL PROTECTED]
Subject: Introduce union stack.
Adds union stack infrastructure to the dentry structure and provides
locking routines to walk the union stack.
Signed-off-by: Jan Blunck [EMAIL PROTECTED]
Signed-off-by: Bharata B Rao [EMAIL PROTECTED]
---
fs/Makefile
On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote:
From: Jan Blunck [EMAIL PROTECTED]
Subject: Introduce union stack.
Adds union stack infrastructure to the dentry structure and provides
locking routines to walk the union stack.
Signed-off-by: Jan Blunck [EMAIL PROTECTED]
On May 14 2007 15:10, Bharata B Rao wrote:
+struct union_info * union_alloc(void)
Ultimate nitpick: try s/\* /*/; (also elsewhere)
+static inline void union_lock(struct dentry *dentry)
+{
+ if (unlikely(dentry dentry-d_union)) {
+ struct union_info *ui = dentry-d_union;
+
+
On May 14 2007 13:23, Badari Pulavarty wrote:
+static inline void union_lock_fs(struct fs_struct *fs)
+{
+int locked;
+
+while (fs) {
+locked = union_trylock(fs-root);
+if (!locked)
+goto loop1;
+locked =
On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote:
From: Jan Blunck [EMAIL PROTECTED]
Subject: Introduce union stack.
Adds union stack infrastructure to the dentry structure and provides
locking routines to walk the union stack.
...
--- /dev/null
+++ b/include/linux/dcache_union.h
20 matches
Mail list logo